Skip to content

Conversation

@orhun
Copy link
Owner

@orhun orhun commented Sep 15, 2024

Description

This PR fixes the issue where the tag date is always set to now() although it should be the date of the existing tag when --tag is used.

Motivation and Context

see #796

How Has This Been Tested?

Fixtures / locally.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@orhun orhun changed the title fix(changelog): do not change the tag date if it already exists fix(changelog): do not change the tag date if tag already exists Sep 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2024

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.21%. Comparing base (c2db791) to head (c1a6fd7).
⚠️ Report is 196 commits behind head on main.

Files with missing lines Patch % Lines
git-cliff/src/lib.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #861      +/-   ##
==========================================
- Coverage   40.31%   40.21%   -0.09%     
==========================================
  Files          21       21              
  Lines        1665     1669       +4     
==========================================
  Hits          671      671              
- Misses        994      998       +4     
Flag Coverage Δ
unit-tests 40.21% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@orhun orhun merged commit fbb643b into main Sep 21, 2024
59 of 61 checks passed
@orhun orhun deleted the fix/unchanged_tag_date branch September 21, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants