Skip to content

fix: allow environment overwrites when using built in configurations#961

Merged
orhun merged 3 commits intoorhun:mainfrom
weichweich:allow-env-overwrites-for-builtin-config
Jan 22, 2025
Merged

fix: allow environment overwrites when using built in configurations#961
orhun merged 3 commits intoorhun:mainfrom
weichweich:allow-env-overwrites-for-builtin-config

Conversation

@weichweich
Copy link
Contributor

Description

Allow environment variables to overwrite built in configurations.

Motivation and Context

It is not possible to use environment overwrites when using a built in configuration (i.e. git-cliff -c githhub). e.g. setting GIT_CLIFF__CHANGELOG__HEADER wouldn't change the appropriate value of the example configuration.

How Has This Been Tested?

export GIT_CLIFF__CHANGELOG__HEADER="This is a different header"

git-cliff -c github

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@weichweich weichweich requested a review from orhun as a code owner November 22, 2024 16:19
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 42.70%. Comparing base (1b779a6) to head (978d4f1).

Files with missing lines Patch % Lines
git-cliff-core/src/embed.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
- Coverage   42.75%   42.70%   -0.04%     
==========================================
  Files          21       21              
  Lines        1743     1745       +2     
==========================================
  Hits          745      745              
- Misses        998     1000       +2     
Flag Coverage Δ
unit-tests 42.70% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@orhun orhun merged commit 7ba3b55 into orhun:main Jan 22, 2025
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants