Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update orientdb.sh startup script to allow us to set CONFIG_FILE and various variables #1219

Open
infected817 opened this Issue Dec 18, 2012 · 2 comments

Comments

Projects
None yet
4 participants

orientdb.sh is a very nice init script for Linux machines. However, I feel that we should be able to set things like CONFIG_FILE and so on within orientdb.sh

These can then be passed to server.sh and shutdown.sh and other when they are called.

Doing so will improve maintainability when we upgrade orientdb. In this case, we can simply modify the appropriate variables in orientdb.sh and move that to /etc/init.d while leaving server.sh and shutdown.sh alone.

As it stands, we need to modify server.sh and shutdown.sh, which leads to a possibility that people will forget to update the values in shutdown.sh and server.sh when they update orientdb. It also makes things more maintainable because all the configuration values for starting up and shutting down orientdb is in 1 central place.

@pellyadolfo : Thanks for the link :)

I had a look, but it looks like those parameters are to be passed to the orientdb server binary and not server.sh. That is currently what is being done inside server.sh though.

I am proposing, that server.sh be updated so it can take arguments which are supplied by orientdb.sh and then pass that to the orientdb server binary.

@lvca lvca added the enhancement label Oct 4, 2014

@lvca lvca added this to the 2.1 milestone Oct 4, 2014

@tglman tglman was assigned by lvca Oct 4, 2014

@lvca lvca modified the milestone: 2.1-rc1, 2.1-rc2 Apr 1, 2015

@lvca lvca modified the milestone: 2.2, 2.1-rc2 Apr 14, 2015

@lvca lvca modified the milestone: 2.2.0-beta, 2.2.0-rc1 Dec 13, 2015

@lvca lvca modified the milestone: 2.2.0-rc1, 2.2.0 GA May 7, 2016

@tglman tglman modified the milestone: 3.0, 2.2.0 GA May 9, 2016

@lvca lvca modified the milestone: 3.1, 3.0 Aug 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment