Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Screens and screen sections were not found in references when li… #1044

Merged
merged 2 commits into from Oct 31, 2022
Merged

FIX: Screens and screen sections were not found in references when li… #1044

merged 2 commits into from Oct 31, 2022

Conversation

JindrichSusen
Copy link
Contributor

…nked to an UiAction by a screen condition

@origambot
Copy link

This pull request has been mentioned on ORIGAM Community. There might be relevant details there:

https://community.origam.com/t/architect-screen-screen-section-references-not-found-for-ui-action/2539/4

@JindrichSusen
Merge branch 'master' into ui-action-references
70eab10 
# Conflicts:
#	backend/Origam.DA.Service/ReferenceIndexManager.cs
@washibana washibana merged commit bf01758 into master Oct 31, 2022
@washibana washibana deleted the ui-action-references branch October 31, 2022 12:43
tvavrda
tvavrda reviewed Nov 6, 2022
View reviewed changes
Copy link
Contributor

@tvavrda tvavrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. References are to be returned by each model element by overriding GetExtraDependencies method.
See example here:

origam/backend/Origam.Schema.LookupModel/SchemaItems/DataLookupMenuBinding.cs

Line 59 in 0ddd607

public override void GetExtraDependencies(System.Collections.ArrayList dependencies)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvavrda tvavrda tvavrda left review comments

@washibana washibana washibana approved these changes

@JiriPrajz JiriPrajz Awaiting requested review from JiriPrajz

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JindrichSusen @origambot @tvavrda @washibana