From a802f438539ab61770636916976d68a4f48ae3b0 Mon Sep 17 00:00:00 2001
From: Jindrich Susen <jindrich.susen@advantages.cz>
Date: Tue, 28 Nov 2023 12:39:46 +0100
Subject: [PATCH 1/3] Added action id

for easier debugging
---
 .../src/gui/Components/DataViewHeader/DataViewHeaderButton.tsx  | 2 ++
 .../gui/Components/DataViewHeader/DataViewHeaderButtonGroup.tsx | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/frontend-html/src/gui/Components/DataViewHeader/DataViewHeaderButton.tsx b/frontend-html/src/gui/Components/DataViewHeader/DataViewHeaderButton.tsx
index d1301f31dc..e0c21ba569 100644
--- a/frontend-html/src/gui/Components/DataViewHeader/DataViewHeaderButton.tsx
+++ b/frontend-html/src/gui/Components/DataViewHeader/DataViewHeaderButton.tsx
@@ -26,9 +26,11 @@ export const DataViewHeaderButton: React.FC<{
   isHidden?: boolean;
   disabled?: boolean;
   title?: string;
+  id?: string;
   onClick?(event: any): void;
 }> = (props) => (
   <button
+    id={props.id}
     title={props.title}
     ref={props.domRef}
     className={cx(props.disabled ? S.disabled : S.enabled, S.root, {hidden: props.isHidden})}
diff --git a/frontend-html/src/gui/Components/DataViewHeader/DataViewHeaderButtonGroup.tsx b/frontend-html/src/gui/Components/DataViewHeader/DataViewHeaderButtonGroup.tsx
index 1fa61bc61f..096133f59c 100644
--- a/frontend-html/src/gui/Components/DataViewHeader/DataViewHeaderButtonGroup.tsx
+++ b/frontend-html/src/gui/Components/DataViewHeader/DataViewHeaderButtonGroup.tsx
@@ -51,6 +51,7 @@ export class DataViewHeaderButtonGroup extends React.Component<{
             <Observer key={action.id}>
               {() => (
                 <DataViewHeaderButton
+                  id={action.id}
                   title={action.caption}
                   disabled={!getIsEnabledAction(action)}
                   onClick={() => setDropped(true)}
@@ -85,6 +86,7 @@ export class DataViewHeaderButtonGroup extends React.Component<{
       <Observer key={action.id}>
         {() => (
           <DataViewHeaderButton
+            id={action.id}
             title={action.caption}
             onClick={(event) => uiActions.actions.onActionClick(action)(event, action)}
             disabled={!getIsEnabledAction(action)}

From e30f66c798cf02fefe780d62c83c2200f403f4ed Mon Sep 17 00:00:00 2001
From: Jindrich Susen <jindrich.susen@advantages.cz>
Date: Tue, 28 Nov 2023 12:47:03 +0100
Subject: [PATCH 2/3] Selection checkbox state was not updated after data in
 the table was changed

caused some action buttons to be disabled when they should not have been because the rows that caused the buttons to be hidden were not it the dataView anymore
---
 frontend-html/src/model/entities/DataView.ts         | 10 ++++++++++
 frontend-html/src/model/entities/ListRowContainer.ts |  1 +
 frontend-html/src/model/entities/types/IDataView.ts  |  2 ++
 3 files changed, 13 insertions(+)

diff --git a/frontend-html/src/model/entities/DataView.ts b/frontend-html/src/model/entities/DataView.ts
index 9e1dd7241d..6d47ffbbf8 100644
--- a/frontend-html/src/model/entities/DataView.ts
+++ b/frontend-html/src/model/entities/DataView.ts
@@ -313,6 +313,16 @@ export class DataView implements IDataView {
     this.selectAllCheckboxChecked = false;
   }
 
+  updateSelectedIds() {
+    const currentRowIds = this.dataTable.rows
+      .map(row => this.dataTable.getRowId(row));
+    for (let rowId of Array.from(this.selectedRowIds)) {
+      if (!currentRowIds.includes(rowId)) {
+        this.selectedRowIds.delete(rowId);
+      }
+    }
+  }
+
   @action.bound
   clear() {
     this.selectedRowIds.clear();
diff --git a/frontend-html/src/model/entities/ListRowContainer.ts b/frontend-html/src/model/entities/ListRowContainer.ts
index b97187ed7d..42118a60e1 100644
--- a/frontend-html/src/model/entities/ListRowContainer.ts
+++ b/frontend-html/src/model/entities/ListRowContainer.ts
@@ -136,6 +136,7 @@ export class ListRowContainer implements IRowsContainer {
         }
         self.sortedIds = rows.map(row => self.rowIdGetter(row));
         const dataView = getDataView(self);
+        dataView.updateSelectedIds();
         if (!data?.retainPreviousSelection) {
           dataView.reselectOrSelectFirst();
         }
diff --git a/frontend-html/src/model/entities/types/IDataView.ts b/frontend-html/src/model/entities/types/IDataView.ts
index 3fc7c6c1f9..e6830b8d59 100644
--- a/frontend-html/src/model/entities/types/IDataView.ts
+++ b/frontend-html/src/model/entities/types/IDataView.ts
@@ -207,6 +207,8 @@ export interface IDataView extends IDataViewData {
   isLazyLoading: Boolean;
 
   insertRecord(index: number, row: any[], shouldLockNewRowAtTop?: boolean): Promise<any>;
+
+  updateSelectedIds(): void;
 }
 
 export const isIDataView = (o: any): o is IDataView => o?.$type_IDataView;

From ab9e9c88f36a29b0a225ba043ad565a7dee5120c Mon Sep 17 00:00:00 2001
From: Jindrich Susen <jindrich.susen@advantages.cz>
Date: Tue, 28 Nov 2023 16:02:10 +0100
Subject: [PATCH 3/3] Select all checkbox in the header was checked after a
 data update in the grid

---
 frontend-html/src/model/entities/DataView.ts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/frontend-html/src/model/entities/DataView.ts b/frontend-html/src/model/entities/DataView.ts
index 6d47ffbbf8..9ef205fe59 100644
--- a/frontend-html/src/model/entities/DataView.ts
+++ b/frontend-html/src/model/entities/DataView.ts
@@ -321,6 +321,8 @@ export class DataView implements IDataView {
         this.selectedRowIds.delete(rowId);
       }
     }
+    this.selectAllCheckboxChecked = currentRowIds.length > 0
+      && currentRowIds.every(rowId => this.selectedRowIds.has(rowId));
   }
 
   @action.bound