New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements semigroup and monoid for Maybe. #125

Merged
merged 1 commit into from May 30, 2017

Conversation

Projects
None yet
2 participants
@diasbruno
Contributor

diasbruno commented May 23, 2017

Implements semigroup and monoid for Maybe.

Show outdated Hide outdated src/data/maybe/maybe.js
Show outdated Hide outdated src/data/maybe/maybe.js
Show outdated Hide outdated src/data/maybe/maybe.js
Show outdated Hide outdated src/data/maybe/maybe.js
@robotlolita

This comment has been minimized.

Show comment
Hide comment
@robotlolita

robotlolita May 26, 2017

Member

Looks neat, thanks! :)

I've requested a few simple changes and then it's ready to be merged :)

Member

robotlolita commented May 26, 2017

Looks neat, thanks! :)

I've requested a few simple changes and then it's ready to be merged :)

@diasbruno

This comment has been minimized.

Show comment
Hide comment
@diasbruno

diasbruno May 27, 2017

Contributor

hmm, I've forgot to remove those when you fixed the test issue. :)
Is anything else missing? (docs...)

Contributor

diasbruno commented May 27, 2017

hmm, I've forgot to remove those when you fixed the test issue. :)
Is anything else missing? (docs...)

@robotlolita

This comment has been minimized.

Show comment
Hide comment
@robotlolita

robotlolita May 27, 2017

Member

Nice 👍

Could you add an authors metadata to the methods you've added? Like:

/*~
 * authors:
 *   - "@diasbruno"
 * type: |
 *   ...
 */

If you're up to writing docs too, a short description with usage examples (as explained here) would be neat! In this case, the category for empty would be Constructing, and the category for concat would be Combining.

Member

robotlolita commented May 27, 2017

Nice 👍

Could you add an authors metadata to the methods you've added? Like:

/*~
 * authors:
 *   - "@diasbruno"
 * type: |
 *   ...
 */

If you're up to writing docs too, a short description with usage examples (as explained here) would be neat! In this case, the category for empty would be Constructing, and the category for concat would be Combining.

@diasbruno

This comment has been minimized.

Show comment
Hide comment
@diasbruno

diasbruno May 29, 2017

Contributor

I tried to write all the docs, but metamagical was not happy and it could not parse the full comment. So this should be ready to merge.

Hope to take some time to hack with metamagical (seems pretty cool).
I'll provide the error I got later.

Contributor

diasbruno commented May 29, 2017

I tried to write all the docs, but metamagical was not happy and it could not parse the full comment. So this should be ready to merge.

Hope to take some time to hack with metamagical (seems pretty cool).
I'll provide the error I got later.

@robotlolita

This comment has been minimized.

Show comment
Hide comment
@robotlolita

robotlolita May 30, 2017

Member

No worries :) Thanks

Member

robotlolita commented May 30, 2017

No worries :) Thanks

@robotlolita robotlolita merged commit 573c2bf into origamitower:master May 30, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 88.424%
Details

@wafflebot wafflebot bot removed the in progress label May 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment