New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Success value in `notEmpty` validation example #154

Merged
merged 1 commit into from Sep 6, 2017

Conversation

Projects
None yet
2 participants
@scotttrinh
Contributor

scotttrinh commented Sep 6, 2017

I was reading through the Validation documentation and noticed this little typo(?). I'm correct in assuming that the validators should return their value property in a Success, not the field, right?

Sorry about the extra \n at EOF. I made this patch with the Github editor and it looks like it just tacked that on. I can kill it if y'all prefer. Making the change in the markdown file made this comment moot.

@robotlolita

This comment has been minimized.

Show comment
Hide comment
@robotlolita

robotlolita Sep 6, 2017

Member

Ah, the newline at the end is fine. But since the documentation is auto-generated, could you edit this Markdown file instead? https://github.com/origamitower/folktale/blob/master/annotations/source/en/validation/index.md

Member

robotlolita commented Sep 6, 2017

Ah, the newline at the end is fine. But since the documentation is auto-generated, could you edit this Markdown file instead? https://github.com/origamitower/folktale/blob/master/annotations/source/en/validation/index.md

@scotttrinh

This comment has been minimized.

Show comment
Hide comment
@scotttrinh

scotttrinh Sep 6, 2017

Contributor

@robotlolita Should both files be edited in the final PR?

Contributor

scotttrinh commented Sep 6, 2017

@robotlolita Should both files be edited in the final PR?

@robotlolita

This comment has been minimized.

Show comment
Hide comment
@robotlolita

robotlolita Sep 6, 2017

Member

No, just the Markdown one.

Member

robotlolita commented Sep 6, 2017

No, just the Markdown one.

Fix Success value in `notEmpty` validation example
I was reading through the `Validation` documentation and noticed this little typo. I'm correct in assuming that the validators should return their `value` property in a `Success`, not the `field`, right?

@robotlolita robotlolita merged commit 461d773 into origamitower:master Sep 6, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 90.079%
Details
@robotlolita

This comment has been minimized.

Show comment
Hide comment
@robotlolita

robotlolita Sep 6, 2017

Member

Thanksies :)

Member

robotlolita commented Sep 6, 2017

Thanksies :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment