New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for some fantasy-land stuff #43

Merged
merged 6 commits into from Oct 9, 2016

Conversation

Projects
None yet
1 participant
@robotlolita
Member

robotlolita commented Oct 9, 2016

Following the work on #37, and addressing #39, this patch moves the Fantasy Land interface to aliases of the actual methods in Folktale structures. The new provide-fantasy-land-aliases module takes care of handling the aliases automatically, so this allows us to diverge our public API from Fantasy Land interfaces as well (avoiding issues like this recent PR fantasyland/fantasy-land#145), as long as we can map it to the interfaces. It also allows us to choose better names (e.g.: .apply() instead of .ap()).

Closes #39.

@robotlolita robotlolita added this to the v2.0.0 milestone Oct 9, 2016

@robotlolita robotlolita merged commit 6fa5fd1 into master Oct 9, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@robotlolita robotlolita deleted the patch/refactor-fl branch Oct 9, 2016

@robotlolita robotlolita removed the in progress label Oct 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment