It should be possible to skip findAndRegisterModules in JacksonSnapshotSerializer
#148
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ObjectMapper#findAndRegisterModulesis not skipable by a subclass ofJacksonSnapshotSerializer. This means all Modules in the classpath which supports registering via service loader will be registered. This is not always what is needed, like in our case:We use in our porject production code Afterburner (if JRE is <= 8) and Blackbird (if JRE is > 8). We have a switch when our ObjectMapper is configured, like this:
With this change a subclass of
JacksonSnapshotSerializercan decide in itsconfigureoverride ifObjectMapper#findAndRegisterModulesshould be executed (just callsuper) or if (like in our case) the impl should register needed modules manually (don't callsuper).