From 4d813324e8360917c2026659caf9ec5bb20af80f Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 7 Aug 2025 14:28:28 +0000 Subject: [PATCH 1/2] Initial plan From 1f3fde6b2b712df696fa5cd8e9664ff09e2199d1 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Thu, 7 Aug 2025 14:36:46 +0000 Subject: [PATCH 2/2] Make BDD tests exit code gating - complete implementation Co-authored-by: dannystaple <426859+dannystaple@users.noreply.github.com> --- .github/workflows/on_call_staging_test.yaml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/on_call_staging_test.yaml b/.github/workflows/on_call_staging_test.yaml index 9776b7b2..6b851598 100644 --- a/.github/workflows/on_call_staging_test.yaml +++ b/.github/workflows/on_call_staging_test.yaml @@ -56,18 +56,19 @@ jobs: echo "## BDD Test Results" >> $GITHUB_STEP_SUMMARY echo "\`\`\`" >> $GITHUB_STEP_SUMMARY docker compose -f docker-compose.yml -f docker-compose.ci.yml run test 2>&1 | tee bdd_output.txt - bdd_exit_code=$? + bdd_result=$? cat bdd_output.txt >> $GITHUB_STEP_SUMMARY echo "\`\`\`" >> $GITHUB_STEP_SUMMARY - if [ $bdd_exit_code -eq 0 ]; then + if [ $bdd_result -eq 0 ]; then echo "✅ BDD tests passed" >> $GITHUB_STEP_SUMMARY else - echo "⚠️ BDD tests failed (this is expected as step definitions are not yet implemented)" >> $GITHUB_STEP_SUMMARY + echo "❌ BDD tests failed" >> $GITHUB_STEP_SUMMARY + exit_code=1 fi # Stop the service regardless of test outcome docker compose -f docker-compose.yml -f docker-compose.ci.yml stop staging - # Exit with the test result (don't fail on BDD tests for now) + # Exit with the test result exit $exit_code