added branch-alias #15

Merged
merged 1 commit into from Jun 4, 2013

Projects

None yet

3 participants

@dmecke
Contributor
dmecke commented Apr 8, 2013

Currently it's only possible to refer to this bundle via dev-master. This could cause trouble when changes are introduced later which break compatibility. With a branch-alias people can refer to 1.0.* and BC-breaks can be introduced in a new version.

@LouTerrailloune

A tag could also be a god idea (if the bundle is stable)

@shieldo shieldo and 1 other commented on an outdated diff Jun 4, 2013
composer.json
@@ -18,6 +18,11 @@
"require": {
"symfony/framework-bundle": ">=2.0,<2.3-dev"
},
+ "extra": {
+ "branch-alias": {
+ "dev-master": "1.0.*"
+ }
+ }
@shieldo
shieldo Jun 4, 2013 Collaborator

There's a comma missing here after the final brace.

@dmecke
dmecke Jun 4, 2013 Contributor

uh, sorry! i've added it now

@shieldo
Collaborator
shieldo commented Jun 4, 2013

@LouTerrailloune once I've dealt with outstanding issues I plan to tag.

@shieldo
Collaborator
shieldo commented Jun 4, 2013

Would you be able to squash down the two commits in this PR into one? I'm keen to merge this!

@dmecke
Contributor
dmecke commented Jun 4, 2013

done!

@shieldo shieldo commented on an outdated diff Jun 4, 2013
composer.json
@@ -18,6 +18,11 @@
"require": {
"symfony/framework-bundle": ">=2.0,<2.3-dev"
},
+ "extra": {
+ "branch-alias": {
+ "dev-master": "1.0.*"
@shieldo
shieldo Jun 4, 2013 Collaborator

Can this be changed to 1.0.x-dev, as per http://getcomposer.org/doc/articles/aliases.md#branch-alias? (Sorry, I should have specified that before!)

I'll merge as soon as that's done.

@dmecke
Contributor
dmecke commented Jun 4, 2013

done as well ;-)

@shieldo shieldo merged commit ab65966 into ornicar:master Jun 4, 2013
@shieldo
Collaborator
shieldo commented Jun 4, 2013

Thanks for this patch, and for bearing with me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment