[RFC] Support pre promotions #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Premove a pawn to the eighth rank. Previously: Wait for the reply. Then the promotion dialog pops up. Now: You select the promotion piece type and it gets played once there is a reponse.
|
Very nice. I tested it and couldn't find a bug. But I noticed a behavior that might be improved.
Can this be handled better? |
|
I'm merging it anyway, since it's better than master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Premove a pawn to the eighth rank.
Previously: Wait for the reply. Then the promotion dialog pops up.
Now: You select the promotion piece type and it gets played once there
is a reponse.