Permalink
Browse files

Make last argument optional in HttpClient::doRequest

  • Loading branch information...
1 parent 0e03542 commit da66e04abe00495cd20e0d1e3843913ff4add335 @ornicar committed Apr 17, 2011
Showing with 4 additions and 4 deletions.
  1. +1 −1 README.markdown
  2. +1 −1 lib/Github/HttpClient.php
  3. +1 −1 lib/Github/HttpClient/Curl.php
  4. +1 −1 test/Github/Tests/HttpClientTest.php
View
@@ -487,7 +487,7 @@ If you want to use your own http client implementation, inject it to the Github_
// create a custom http client
class MyHttpClient extends Github_HttpClient
{
- public function doRequest($url, array $parameters = array(), $httpMethod = 'GET', array $options)
+ public function doRequest($url, array $parameters = array(), $httpMethod = 'GET', array $options = array())
{
// send the request and return the raw response
}
@@ -45,7 +45,7 @@ public function __construct(array $options = array())
*
* @return string HTTP response
*/
- abstract protected function doRequest($url, array $parameters = array(), $httpMethod = 'GET', array $options);
+ abstract protected function doRequest($url, array $parameters = array(), $httpMethod = 'GET', array $options = array());
/**
* Send a GET request
@@ -18,7 +18,7 @@ class Github_HttpClient_Curl extends Github_HttpClient
*
* @return string HTTP response
*/
- public function doRequest($url, array $parameters = array(), $httpMethod = 'GET', array $options)
+ public function doRequest($url, array $parameters = array(), $httpMethod = 'GET', array $options = array())
{
$curlOptions = array();
@@ -78,7 +78,7 @@ protected function getHttpClientMockBuilder()
class Github_HttpClient_TestDriver extends Github_HttpClient
{
- protected function doRequest($url, array $parameters = array(), $httpMethod = 'GET', array $options)
+ protected function doRequest($url, array $parameters = array(), $httpMethod = 'GET', array $options = array())
{
}

0 comments on commit da66e04

Please sign in to comment.