New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oro:auto-loading-bundles:list command to preview the ordering of bundles... #233

Closed
wants to merge 1 commit into
base: master
from

Conversation

6 participants
@nnmer
Contributor

nnmer commented Feb 26, 2015

command to list bundles auto loading and their order

@hurricane-voronin

This comment has been minimized.

Show comment
Hide comment
@hurricane-voronin

hurricane-voronin Aug 19, 2015

Contributor

Hi @nnmer, thank you for the PR.
Could you please provide us with information for which cases you need this command.
As an alternative of this command you can see this information in the cache directory: cache/{environment}/bundles.php

Contributor

hurricane-voronin commented Aug 19, 2015

Hi @nnmer, thank you for the PR.
Could you please provide us with information for which cases you need this command.
As an alternative of this command you can see this information in the cache directory: cache/{environment}/bundles.php

@nnmer

This comment has been minimized.

Show comment
Hide comment
@nnmer

nnmer Oct 30, 2015

Contributor

Hi @hurricane-voronin .
The command will show me the order of bundles together with the priority that was set to them. So i can easily see what priority i need to set to new bundle if i need to load it in specific order. Using
cache/{environment}/bundles.php
I cannot do what I described above.

Contributor

nnmer commented Oct 30, 2015

Hi @hurricane-voronin .
The command will show me the order of bundles together with the priority that was set to them. So i can easily see what priority i need to set to new bundle if i need to load it in specific order. Using
cache/{environment}/bundles.php
I cannot do what I described above.

@iklymenko

This comment has been minimized.

Show comment
Hide comment
@iklymenko

iklymenko Nov 11, 2015

Contributor

@nnmer, thanks for the explanation! I have additional question. In the command output there is third column in the grid that shows the bundles which requires Kernel object in the bundle class. How this information could be useful?
Also, I want to note that it is not obvious for the user what kind information this column shows.

Contributor

iklymenko commented Nov 11, 2015

@nnmer, thanks for the explanation! I have additional question. In the command output there is third column in the grid that shows the bundles which requires Kernel object in the bundle class. How this information could be useful?
Also, I want to note that it is not obvious for the user what kind information this column shows.

->setName('oro:auto-loading-bundles:list')
->setDescription('List auto loading bundles by their priority');;
}
protected function execute(InputInterface $input, OutputInterface $output)

This comment has been minimized.

@iklymenko

iklymenko Nov 11, 2015

Contributor

Missing import of the Symfony\Component\Console\Output\OutputInterface namespace

@iklymenko

iklymenko Nov 11, 2015

Contributor

Missing import of the Symfony\Component\Console\Output\OutputInterface namespace

namespace Oro\Bundle\DistributionBundle\Command;
use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
use Symfony\Component\Console\Input\InputArgument;

This comment has been minimized.

@iklymenko

iklymenko Nov 11, 2015

Contributor

This namespace is unused, so could be deleted.

@iklymenko

iklymenko Nov 11, 2015

Contributor

This namespace is unused, so could be deleted.

@@ -121,7 +121,7 @@ function (\SplFileInfo $current) use (&$paths) {
/**
* @return array
*/
protected function collectBundles()
public function collectBundles()

This comment has been minimized.

@yshyshkin

yshyshkin Nov 17, 2015

Contributor

Instead of making this method public (that is not really good), please, move search and collection logic to separate class, and reuse it in both cases without making method collectBundles() public. Class can be called e.g. Oro\Bundle\DistributionBundle\Bundle\Collector.

@yshyshkin

yshyshkin Nov 17, 2015

Contributor

Instead of making this method public (that is not really good), please, move search and collection logic to separate class, and reuse it in both cases without making method collectBundles() public. Class can be called e.g. Oro\Bundle\DistributionBundle\Bundle\Collector.

@orocla

This comment has been minimized.

Show comment
Hide comment
@orocla

orocla Dec 22, 2015

Thank you for your pull request.

It looks like this may be your first contribution to an Oro, Inc. open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at http://www.orocrm.com/contributor-license-agreement/

If you've already signed the CLA, it's possible we don't have your GitHub username or you're using a different email address. GitHub uses the email address you set in your local Git configuration to associate commits with your GitHub account. Please sign the CLA again using the correct GitHub username and email address or see this help article on setting the email on your git commits.

Once you've signed the CLA, please allow for about an hour for the submission to be processed.

orocla commented Dec 22, 2015

Thank you for your pull request.

It looks like this may be your first contribution to an Oro, Inc. open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at http://www.orocrm.com/contributor-license-agreement/

If you've already signed the CLA, it's possible we don't have your GitHub username or you're using a different email address. GitHub uses the email address you set in your local Git configuration to associate commits with your GitHub account. Please sign the CLA again using the correct GitHub username and email address or see this help article on setting the email on your git commits.

Once you've signed the CLA, please allow for about an hour for the submission to be processed.

@orocla orocla added the cla: no label Dec 22, 2015

@nnmer

This comment has been minimized.

Show comment
Hide comment
@nnmer

nnmer Dec 23, 2015

Contributor

ignore this PR, i will not do any contributions in future.

Contributor

nnmer commented Dec 23, 2015

ignore this PR, i will not do any contributions in future.

@DimaSoroka

This comment has been minimized.

Show comment
Hide comment
@DimaSoroka

DimaSoroka Dec 23, 2015

Contributor

Thanks @nnmer, I hope OroPlatform was helpful for you and you'll change your mind in future.

Contributor

DimaSoroka commented Dec 23, 2015

Thanks @nnmer, I hope OroPlatform was helpful for you and you'll change your mind in future.

@DimaSoroka DimaSoroka closed this Dec 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment