New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.8] Fixed data migration bugs in address type/country #392

Merged
merged 1 commit into from Feb 16, 2016

Conversation

5 participants
@sbani
Contributor

sbani commented Feb 9, 2016

Issue: #390
Cherry picked: 459e826 from #369
See #369 for detailed info

Fixed data migration bugs in address type/country
If you added anouther language you got an error during migration, because
country or type tried to be insert multiple times which caused an integraty
violation

Closes #390

@orocla orocla added the cla: yes label Feb 9, 2016

@alex-n-2k7

This comment has been minimized.

Show comment
Hide comment
@alex-n-2k7

alex-n-2k7 Feb 9, 2016

Contributor

Hi @sbani , Thanks for the contribution. Merged.

Contributor

alex-n-2k7 commented Feb 9, 2016

Hi @sbani , Thanks for the contribution. Merged.

@sbani

This comment has been minimized.

Show comment
Hide comment
@sbani

sbani Feb 12, 2016

Contributor

When do you plan to release the bug fix?

Contributor

sbani commented Feb 12, 2016

When do you plan to release the bug fix?

@DimaSoroka

This comment has been minimized.

Show comment
Hide comment
@DimaSoroka

DimaSoroka Feb 12, 2016

Contributor

We are going to have release on Monday.

Contributor

DimaSoroka commented Feb 12, 2016

We are going to have release on Monday.

@sbani

This comment has been minimized.

Show comment
Hide comment
@sbani

sbani Feb 14, 2016

Contributor

Thanks!

Contributor

sbani commented Feb 14, 2016

Thanks!

@sbani

This comment has been minimized.

Show comment
Hide comment
@sbani

sbani Feb 16, 2016

Contributor

Do you still plan to release the 1.8.3?
I think a bug, which will not allow users to install or update Oro is a bigger one and shouldn't be shunted to a later time.
I mean till yesterday 1.8 was the official stable version and the bug was reported by myself 28 days ago. This means there was no bug fix of a known bug in stable version for 28 days although I created a PR directly.

Contributor

sbani commented Feb 16, 2016

Do you still plan to release the 1.8.3?
I think a bug, which will not allow users to install or update Oro is a bigger one and shouldn't be shunted to a later time.
I mean till yesterday 1.8 was the official stable version and the bug was reported by myself 28 days ago. This means there was no bug fix of a known bug in stable version for 28 days although I created a PR directly.

iklymenko added a commit that referenced this pull request Feb 16, 2016

Merge pull request #392 from sbani/fix-1.8
[1.8] Fixed data migration bugs in address type/country

@iklymenko iklymenko merged commit b7094f8 into oroinc:1.8 Feb 16, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@sbani sbani deleted the sbani:fix-1.8 branch Feb 16, 2016

@DimaSoroka

This comment has been minimized.

Show comment
Hide comment
@DimaSoroka

DimaSoroka Feb 16, 2016

Contributor

@sbani, we are not going to release 1.8.3 community version as 1.9.0 already released and includes this bug fix, we do bug fix releases for enterprise edition only.
All bug fix contribution to maintenance brunches could be used by changing version dependency to "version-dev" (1.8.x-dev in this case). We'll update our contribution guide shortly to make this clear.

Contributor

DimaSoroka commented Feb 16, 2016

@sbani, we are not going to release 1.8.3 community version as 1.9.0 already released and includes this bug fix, we do bug fix releases for enterprise edition only.
All bug fix contribution to maintenance brunches could be used by changing version dependency to "version-dev" (1.8.x-dev in this case). We'll update our contribution guide shortly to make this clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment