Fix DRAIN-EVBUFFER following my APPEND-ARRAY optimization #14

merged 1 commit into from Oct 5, 2012


None yet
2 participants

My optimization broke DRAIN-EVBUFFER because I removed the element-type key-arg and didn't check in the necessary change to DRAIN-EVBUFFER.

orthecreedence added a commit that referenced this pull request Oct 5, 2012

Merge pull request #14 from neonsquare/master
Fix DRAIN-EVBUFFER following my APPEND-ARRAY optimization

@orthecreedence orthecreedence merged commit 4865954 into orthecreedence:master Oct 5, 2012


orthecreedence commented Oct 5, 2012

Thanks =].

BTW, I just introduced an API-breaking change (sorry!). tcp-send no longer takes a socket parameter, it's now only used for opening a connection. It felt weird to me having a bunch of unused parameters like host/port and I didn't want to litter it with more &key arguments than it needs. If you need to send data on an existing tcp connection, use write-socket-data which now takes :read-cb :write-cb :event-cb callbacks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment