New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run go mod tidy and add back go.sum #63

Merged
merged 1 commit into from Nov 10, 2018

Conversation

Projects
None yet
2 participants
@SamWhited
Copy link
Contributor

SamWhited commented Nov 10, 2018

The go.sum file is meant to be committed, it is a trust-on-first-use
based system that prevents versions from being modified upstream and is
necessary in a distributed packaging system.

Running go mod tidy updated the module format to the latest version (just adds comments on indirect modules) and added a few missing deps.

run go mod tidy and add back go.sum
The go.sum file is meant to be committed, it is a trust-on-first-use
based system that prevents versions from being modified upstream and is
necessary in a distributed packaging system.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 10, 2018

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   81.38%   81.38%           
=======================================
  Files          91       91           
  Lines        6388     6388           
=======================================
  Hits         5199     5199           
  Misses        945      945           
  Partials      244      244

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 741a9f4...2514d0b. Read the comment docs.

@ortuman

This comment has been minimized.

Copy link
Owner

ortuman commented Nov 10, 2018

Thank you Sam! 👌🏻

@ortuman ortuman merged commit b5b9260 into ortuman:master Nov 10, 2018

5 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codebeat no reportable quality changes
Details
codecov/patch Coverage not affected when comparing 741a9f4...2514d0b
Details
codecov/project 81.38% remains the same compared to 741a9f4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SamWhited SamWhited deleted the SamWhited:mod_tidy branch Nov 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment