Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hydra+NextJS TypeScript reference implementation #44

Merged
merged 1 commit into from
May 27, 2024

Conversation

amorey
Copy link
Contributor

@amorey amorey commented Jul 27, 2022

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact security@ory.sh) from the
    maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation within the code base (if appropriate).

Further comments

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2022

CLA assistant check
All committers have signed the CLA.

@amorey amorey mentioned this pull request Jul 27, 2022
6 tasks
@vinckr vinckr changed the title Adds Hydra+NextJS TypeScript reference implementation feat: Hydra+NextJS TypeScript reference implementation Jul 27, 2022
@aeneasr aeneasr requested a review from vinckr July 27, 2022 15:37
@vinckr
Copy link
Member

vinckr commented Jun 5, 2023

Hello @amorey
apologies for the very late response here.
Is this a duplicate of #43 ?

@amorey
Copy link
Contributor Author

amorey commented Jun 5, 2023

#43 is for javascript, #44 is for typescript

@rworkduo
Copy link

any reason why this example is not approved after almost 2 years? it looks useful to vast nextjs community that uses typescript

@vinckr
Copy link
Member

vinckr commented May 27, 2024

@rworkduo no good reason. I mostly have not tried it out!
will merge now :-)
thanks for the reminder

@vinckr vinckr merged commit a085b65 into ory:master May 27, 2024
1 check passed
@amorey amorey deleted the hydra-nextjs-ts branch May 27, 2024 11:20
@amorey
Copy link
Contributor Author

amorey commented May 27, 2024

Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants