API generation bug regarding Accept Consent request session model

[matejkramny]

Preflight checklist

• I could not find a solution in the existing issues, docs, nor discussions.
• I agree to follow this project's Code of Conduct.
• I have read and am following this repository's Contribution Guidelines.
• This issue affects my Ory Cloud project.
• I have joined the Ory Community Slack.
• I am signed up to the Ory Security Patch Newsletter.

Describe the bug

The API generates an incorrect definition for the Accept Consent request session data model in the Go api client (ref ory/hydra-client-go#10)

Model in question:
https://github.com/ory/hydra-client-go/blob/master/model_consent_request_session.go#L23

It's type "idToken": map[string]map[string]interface{} when the API docs suggest it is "idToken": map[string]interface{}

The JS (node) api also sends an object of key: string, value: any. The dart api also has a similar mapping, but of String: JSONObject.

The model requires us to define the following body, which is not correct

idToken: {
  email: { email: "hello@email.com" },
  name: { name: "foo bar" },
}

Reproducing the bug

1. Create a login session/ consent
2. OpenAPI consumer crashes (not expecting nested maps)

Relevant log output

n/a

Relevant configuration

n/a

Version

1.11.7

On which operating system are you observing this issue?

Linux

In which environment are you deploying?

Kubernetes

Additional Context

The openapi generator seems to incorrectly assume the value of the map and gives them a map instead

[zepatrik]

Hm looks like a problem with the generator, the spec looks fine. Also if other languages are working properly, this suggests it's a bug in the generator.

[matejkramny]

I've done some digging into how it's generated, it appears to have been a problem before

[aeneasr]

We had this problem in Kratos, a good solution is to remove the type attribute which de-bugs the spec. You can find such an example here: https://github.com/ory/kratos/blob/e50551330d976845c696bf68b6d9b61221da59d3/.schema/openapi/patches/schema.yaml#L2

To apply the patch, add it like so:

https://github.com/ory/kratos/blob/e50551330d976845c696bf68b6d9b61221da59d3/Makefile#L93

[matejkramny]

Thanks @aeneasr I'll create a patch and submit a PR

[matejkramny]

Apologies but I'd lik to reopen as the PR does not correct the definition:

https://github.com/ory/hydra-client-go/blob/master/model_consent_request_session.go#L23

[kotyara85]

This PR didn't seem to fixed the the client repo?
Looking for a fix too
Thanks

[aeneasr]

It's not yet released