Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI clients create command is missing flag to set Metadata #3091

Closed
3 of 6 tasks
rikkuness opened this issue Apr 26, 2022 · 2 comments
Closed
3 of 6 tasks

CLI clients create command is missing flag to set Metadata #3091

rikkuness opened this issue Apr 26, 2022 · 2 comments
Labels
bug Something is not working.

Comments

@rikkuness
Copy link

Preflight checklist

Describe the bug

When creating clients from the CLI, it's not currently possible to set the OAuth2Client.Metadata property.

Reproducing the bug

  1. Run hydra clients create --help and check the flags.

Relevant log output

No response

Relevant configuration

No response

Version

Latest

On which operating system are you observing this issue?

No response

In which environment are you deploying?

Binary

Additional Context

I earlier submitted ory/x#497 which will allow setting OAuth2Client.Metadata to a map[string]string value, which works well for my use case. However looking at the API reference it seems that metadata is a JSONRawMessage or interface{}, so should the CLI permit setting OAuth2Client.Metadata to be arbitrary JSON as a string input, or does a map[string]string suffice for most CLI use cases?

If map[string]string is sufficient I'll submit a PR to add that. Thanks.

@rikkuness rikkuness added the bug Something is not working. label Apr 26, 2022
@aeneasr
Copy link
Member

aeneasr commented Apr 26, 2022

Thank you for the report! The metadata object is indeed a raw JSON string, and the CLI should be able to support it. It could be as easy as --metadata '{"my":"json"}'. WDYT?

rikkuness added a commit to rikkuness/hydra that referenced this issue Apr 26, 2022
@rikkuness
Copy link
Author

Sounds good, I've opened a PR :)

aeneasr pushed a commit to rikkuness/hydra that referenced this issue Apr 27, 2022
aeneasr added a commit that referenced this issue Jun 24, 2022
This patch adds output formats to `hydra create client` and makes all client fields configurable as flags.

Closes #3091
aeneasr added a commit that referenced this issue Jun 24, 2022
This patch adds output formats to `hydra create client` and makes all client fields configurable as flags.

Closes #3091
aeneasr added a commit that referenced this issue Jun 27, 2022
This patch adds output formats to `hydra create client` and makes all client fields configurable as flags.

Closes #3091
aeneasr added a commit that referenced this issue Jun 27, 2022
This patch adds output formats to `hydra create client` and makes all client fields configurable as flags.

Closes #3091
aeneasr added a commit that referenced this issue Jun 27, 2022
This patch adds output formats to `hydra create client` and makes all client fields configurable as flags.

Closes #3091
grantzvolsky pushed a commit that referenced this issue Aug 1, 2022
This patch adds output formats to `hydra create client` and makes all client fields configurable as flags.

Closes #3091
aeneasr added a commit that referenced this issue Aug 1, 2022
This patch adds output formats to `hydra create client` and makes all client fields configurable as flags.

Closes #3091
aeneasr added a commit that referenced this issue Aug 18, 2022
This patch adds output formats to `hydra create client` and makes all client fields configurable as flags.

Closes #3091
aeneasr added a commit that referenced this issue Sep 5, 2022
This patch adds output formats to `hydra create client` and makes all client fields configurable as flags.

Closes #3091
@aeneasr aeneasr closed this as completed in bb9c8ba Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants