Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: Fix description of clients create --subject-type option #1305

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
2 participants
@sawadashota
Copy link
Contributor

commented Mar 7, 2019

Proposed changes

Fix description of clients create --subject-type option
(This was same as --logo-uri)

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact hi@ory.sh) from the maintainers to push the changes.
  • I signed the Developer's Certificate of Origin
    by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
    amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
    force push.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)
cmd: Fix description of clients create --subject-type option
Signed-off-by: Shota SAWADA <xiootas@gmail.com>
@aeneasr

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

Thank you!

@aeneasr aeneasr merged commit fa40b43 into ory:master Mar 7, 2019

7 checks passed

DCO DCO
Details
ci/circleci: build-docker Your tests passed on CircleCI!
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-jwt Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-opaque Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-plugin Your tests passed on CircleCI!
Details

@sawadashota sawadashota deleted the sawadashota:fix-subject-type-desc branch Mar 8, 2019

kminehart added a commit to kminehart/hydra that referenced this pull request Mar 12, 2019

cmd: Fix description of clients create --subject-type option (ory#1305)
Signed-off-by: Shota SAWADA <xiootas@gmail.com>
Signed-off-by: Kevin Minehart <kmineh0151@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.