Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consent: Move to query parameters #1375

Merged
merged 6 commits into from Apr 20, 2019

Conversation

Projects
None yet
1 participant
@aeneasr
Copy link
Member

commented Apr 20, 2019

No description provided.

aeneasr added some commits Apr 19, 2019

oauth2: Resolve memory leak in gorilla/sessions
Closes #1363

Signed-off-by: aeneasr <aeneas@ory.sh>
consent: Move to query parameters
Previously, user and client were sent as path parameters on consent and
login lifecycle endpoints. This patch uses query parameters instead.
This allows developers to use users with slashes and dots without
causing issues with the URI path.

Signed-off-by: aeneasr <aeneas@ory.sh>

@aeneasr aeneasr added the enhancement label Apr 20, 2019

@aeneasr aeneasr added this to the v1.0.0 milestone Apr 20, 2019

@aeneasr aeneasr self-assigned this Apr 20, 2019

@aeneasr aeneasr force-pushed the fix-1363 branch from 44e1bf7 to 6839abd Apr 20, 2019

aeneasr added some commits Apr 20, 2019

u
u
u

@aeneasr aeneasr merged commit 067e498 into master Apr 20, 2019

5 of 7 checks passed

DCO DCO
Details
coverage/coveralls Coverage decreased (-0.1%) to 52.05%
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-jwt Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-opaque Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-plugin Your tests passed on CircleCI!
Details

@aeneasr aeneasr deleted the fix-1363 branch Apr 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.