Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fallback routes and templates #1402

Merged
merged 1 commit into from Apr 30, 2019

Conversation

Projects
None yet
2 participants
@MDrollette
Copy link
Contributor

commented Apr 29, 2019

Proposed changes

Fixes some fallback routes to be named correctly and reference the correct config values.

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact hi@ory.sh) from the maintainers to push the changes.
  • I signed the Developer's Certificate of Origin
    by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
    amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
    force push.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)
fix fallback routes and templates
Signed-off-by: Matt Drollette <matt@drollette.com>

@MDrollette MDrollette force-pushed the MDrollette:fallback branch from 1eea48a to 441bf12 Apr 29, 2019

@aeneasr

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Thank you!

@aeneasr aeneasr merged commit 64f3138 into ory:master Apr 30, 2019

7 checks passed

DCO DCO
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-memory Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-mysql Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-plugin Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-postgres Your tests passed on CircleCI!
Details

@aeneasr aeneasr added this to the v1.0.0 milestone Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.