Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migrate SQL command message regarding config file. #1412

Merged
merged 1 commit into from May 2, 2019

Conversation

Projects
None yet
2 participants
@dkushner
Copy link
Contributor

commented May 1, 2019

Related issue

#1411

Proposed changes

Simple changes the help message output when a user tries to invoke the migrate sql subcommand without specifying a database URL on the command line itself. Currently the message for -e indicates that it will pull from the DSN environment variable but not that it will check the dsn key in the indicated configuration file.

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact hi@ory.sh) from the maintainers to push the changes.
  • I signed the Developer's Certificate of Origin
    by signing my commit(s). You can amend your signature to the most recent commit by using git commit --amend -s. If you
    amend the commit, you might need to force push using git push --force HEAD:<branch>. Please be very careful when using
    force push.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)

@dkushner dkushner force-pushed the dkushner:fix/migrate-message branch 2 times, most recently from b42da0a to 3dfd37c May 1, 2019

David Kushner
Fix migrate SQL command message to indicate that environment flag wil…
…l pull from config file.

Signed-off-by: David Kushner <david.kushner@byton.com>

@dkushner dkushner force-pushed the dkushner:fix/migrate-message branch from 3dfd37c to 3163c3f May 1, 2019

@aeneasr

This comment has been minimized.

Copy link
Member

commented May 2, 2019

Thank you!

@aeneasr aeneasr merged commit 025acfb into ory:master May 2, 2019

7 checks passed

DCO DCO
Details
ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-memory Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-mysql Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-plugin Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-postgres Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.