Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth2: Don't show registration_endpoint if config is undefined #1449

Merged
merged 2 commits into from May 28, 2019

Conversation

Projects
None yet
3 participants
@sawadashota
Copy link
Contributor

commented May 23, 2019

Related issue

#1448

Proposed changes

Don't show registration_endpoint at /.well-known/openid-configuration if config is undefined.

Checklist

  • I have read the contributing guidelines
  • I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security
    vulnerability, I confirm that I got green light (please contact hi@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation within the code base (if appropriate)
  • I have documented my changes in the developer guide (if appropriate)
vendor: Update dependencies
This update occurred when download dependencies

Signed-off-by: Shota Sawada <xiootas@gmail.com>
@CLAassistant

This comment has been minimized.

Copy link

commented May 23, 2019

CLA assistant check
All committers have signed the CLA.

@aeneasr

This comment has been minimized.

Copy link
Member

commented May 23, 2019

Thank you! That makes sense. By the way, I think omitempty works also with empty strings, no need for poimters afaik :)

oauth2: Don't show registration_endpoint if undefined
Signed-off-by: Shota Sawada <xiootas@gmail.com>

@sawadashota sawadashota force-pushed the sawadashota:fix-1448 branch from 0326ae6 to 106cd25 May 23, 2019

@sawadashota

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

Thanks! Your are right!
https://play.golang.org/p/Typ4LJQ85Bl

@sawadashota sawadashota marked this pull request as ready for review May 23, 2019

@aeneasr aeneasr merged commit 6d46786 into ory:master May 28, 2019

8 checks passed

ci/circleci: format Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-cockroach Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-memory Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-mysql Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-plugin Your tests passed on CircleCI!
Details
ci/circleci: test-e2e-postgres Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
@aeneasr

This comment has been minimized.

Copy link
Member

commented May 28, 2019

Thank you!

@sawadashota sawadashota deleted the sawadashota:fix-1448 branch May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.