Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider rename WriteRelationTuples in WriteService #351

Closed
robinbraemer opened this issue Nov 28, 2020 · 0 comments
Closed

Consider rename WriteRelationTuples in WriteService #351

robinbraemer opened this issue Nov 28, 2020 · 0 comments
Assignees
@zepatrik @robinbraemer
Labels
rfc A request for comments to discuss and share ideas.
Milestone
Next Gen Keto - f...

Comments

@robinbraemer
Copy link
Contributor

robinbraemer commented Nov 28, 2020 •
edited

Maybe it’s better to rename this RPC to TransactRelationTuples, because an action may not be a write/insert but a delete or other.

keto/api/keto/acl/v1alpha1/write_service.proto

Line 17 in 921c630

rpc WriteRelationTuples(WriteRelationTuplesRequest) returns (WriteRelationTuplesResponse);

@robinbraemer robinbraemer added the rfc A request for comments to discuss and share ideas. label Nov 28, 2020
zepatrik added a commit that referenced this issue Jan 15, 2021
@zepatrik
chore: rename gRPC data types to proto data types
83a17a8 
Closes #384
Closes #393
Closes #351
@zepatrik zepatrik mentioned this issue Jan 15, 2021
Merged
zepatrik added a commit that referenced this issue Jan 16, 2021
@zepatrik
chore: rename gRPC data types to proto data types (#395)
b6b36ce 
Closes #384
Closes #393
Closes #351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepatrik zepatrik

@robinbraemer robinbraemer

Labels
rfc A request for comments to discuss and share ideas.
Projects
None yet
Milestone
Next Gen Keto - first working version
Development

No branches or pull requests
2 participants
@zepatrik @robinbraemer