From 976cd0dc3dd95c2c1992bfa82394e9fad39f34f2 Mon Sep 17 00:00:00 2001 From: Arne Luenser Date: Thu, 5 Oct 2023 15:57:25 +0200 Subject: [PATCH] fix: adjust tracing verbosity --- identity/manager.go | 15 +++++++++------ persistence/sql/identity/persister_identity.go | 5 +++-- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/identity/manager.go b/identity/manager.go index b47a03c0ac6..11220ec15f1 100644 --- a/identity/manager.go +++ b/identity/manager.go @@ -415,8 +415,9 @@ func (m *Manager) UpdateTraits(ctx context.Context, id uuid.UUID, traits Traits, } func (m *Manager) ValidateIdentity(ctx context.Context, i *Identity, o *ManagerOptions) (err error) { - ctx, span := m.r.Tracer(ctx).Tracer().Start(ctx, "identity.Manager.validate") - defer otelx.End(span, &err) + // This trace is more noisy than it's worth in diagnostic power. + // ctx, span := m.r.Tracer(ctx).Tracer().Start(ctx, "identity.Manager.validate") + // defer otelx.End(span, &err) if err := m.r.IdentityValidator().Validate(ctx, i); err != nil { if _, ok := errorsx.Cause(err).(*jsonschema.ValidationError); ok && !o.ExposeValidationErrors { @@ -429,8 +430,9 @@ func (m *Manager) ValidateIdentity(ctx context.Context, i *Identity, o *ManagerO } func (m *Manager) CountActiveFirstFactorCredentials(ctx context.Context, i *Identity) (count int, err error) { - ctx, span := m.r.Tracer(ctx).Tracer().Start(ctx, "identity.Manager.CountActiveFirstFactorCredentials") - defer otelx.End(span, &err) + // This trace is more noisy than it's worth in diagnostic power. + // ctx, span := m.r.Tracer(ctx).Tracer().Start(ctx, "identity.Manager.CountActiveFirstFactorCredentials") + // defer otelx.End(span, &err) for _, strategy := range m.r.ActiveCredentialsCounterStrategies(ctx) { current, err := strategy.CountActiveFirstFactorCredentials(i.Credentials) @@ -444,8 +446,9 @@ func (m *Manager) CountActiveFirstFactorCredentials(ctx context.Context, i *Iden } func (m *Manager) CountActiveMultiFactorCredentials(ctx context.Context, i *Identity) (count int, err error) { - ctx, span := m.r.Tracer(ctx).Tracer().Start(ctx, "identity.Manager.CountActiveMultiFactorCredentials") - defer otelx.End(span, &err) + // This trace is more noisy than it's worth in diagnostic power. + // ctx, span := m.r.Tracer(ctx).Tracer().Start(ctx, "identity.Manager.CountActiveMultiFactorCredentials") + // defer otelx.End(span, &err) for _, strategy := range m.r.ActiveCredentialsCounterStrategies(ctx) { current, err := strategy.CountActiveMultiFactorCredentials(i.Credentials) diff --git a/persistence/sql/identity/persister_identity.go b/persistence/sql/identity/persister_identity.go index 3e8335c8027..5a31d7bd6f3 100644 --- a/persistence/sql/identity/persister_identity.go +++ b/persistence/sql/identity/persister_identity.go @@ -945,8 +945,9 @@ func (p *IdentityPersister) validateIdentity(ctx context.Context, i *identity.Id } func (p *IdentityPersister) InjectTraitsSchemaURL(ctx context.Context, i *identity.Identity) (err error) { - ctx, span := p.r.Tracer(ctx).Tracer().Start(ctx, "persistence.sql.InjectTraitsSchemaURL") - defer otelx.End(span, &err) + // This trace is more noisy than it's worth in diagnostic power. + // ctx, span := p.r.Tracer(ctx).Tracer().Start(ctx, "persistence.sql.InjectTraitsSchemaURL") + // defer otelx.End(span, &err) ss, err := p.r.IdentityTraitsSchemas(ctx) if err != nil {