Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with Traefik, Nginx, Ambassador, Envoy #263

Open
3 of 12 tasks
mvanderlee opened this issue Sep 24, 2019 · 8 comments
Open
3 of 12 tasks

Integrate with Traefik, Nginx, Ambassador, Envoy #263

mvanderlee opened this issue Sep 24, 2019 · 8 comments
Labels
bug Something is not working. help wanted We are looking for help on this one.
Milestone

Comments

@mvanderlee
Copy link

mvanderlee commented Sep 24, 2019

Is your feature request related to a problem? Please describe.

I'd like to use Ory Oathkeeper with:

Additional info

As per my comment #265 (comment) we would like to offer one endpoint per service:

  • /decisions/generic/... (this is currently /decisions)
  • /decisions/traefik/...
  • ...

For backwards compatibility ideas see https://github.com/ory/oathkeeper/pull/265/files#r329310302

For implementation ideas see this PR: #265

Context

See comment #263 (comment)

@piotrmsc
Copy link

piotrmsc commented Sep 26, 2019

AFAIR oathkeeper already has solution for that, I've been thinking about a similar thing in istio using mixer adapter. Oathkeeper decision API https://www.ory.sh/docs/oathkeeper/sdk/api#access-control-decision-api is what you could use in the middleware. It gives you more less "ok"/ "not ok" responses.
@aeneasr correct me if I'm wrong 👍

@mvanderlee
Copy link
Author

For traefik I'd have to either create a wrapper service to call in the middleware, modify traefik, or modify oathkeeper.

Modifying oathkeeper was the easiest.

Instead of adding a new endpoint, as I've done in the PR, we could make the decision source comfortable for a single endpoint?
I.e. in oathkeeper.yml:
decision:
source: request_path or headers
proto_header: X-Forwarded-Proto
host_header: X-Forwarded-Host
Etc.

@aeneasr aeneasr added bug Something is not working. up for grab labels Mar 18, 2020
@aeneasr aeneasr added this to the v0.37.0 milestone Mar 18, 2020
@aeneasr
Copy link
Member

aeneasr commented Mar 30, 2020

As per my comment #265 (comment) we would like to offer one endpoint per service. So moving the Decisions API in general to /decisions/generic. For backwards compatibility ideas see https://github.com/ory/oathkeeper/pull/265/files#r329310302

For implementation ideas see this PR: #265

Additionally, we should document the set up for the different systems. Let's start with

  • Traefik
  • Nginx
  • Ambassador

in ORY Docs in a new section (e.g. Scenarios -> Using with Traefik / Using with Nginx / ...).

@aeneasr aeneasr changed the title Integrate with Traefik Integrate with Traefik, Nginx, Ambassador, Kong Mar 30, 2020
@aeneasr aeneasr changed the title Integrate with Traefik, Nginx, Ambassador, Kong Integrate with Traefik, Nginx, Ambassador Mar 30, 2020
@aeneasr aeneasr changed the title Integrate with Traefik, Nginx, Ambassador Integrate with Traefik, Nginx, Ambassador, Envoy Mar 30, 2020
@rdehouss
Copy link

rdehouss commented May 7, 2020

Hi! I see 0.38 is moving forward with beta.2, will this feature be done by the time 0.38 is released?
We're using traefik for our API in docker and we'd like to protect them with Oathkeeper, that would be awesome!
Thanks a lot for all your efforts!

@aeneasr
Copy link
Member

aeneasr commented May 7, 2020

As soon as the PR is finished (contributions welcomed) this will be merged and released!

@SvenDowideit
Copy link

Any chance of adding @mholt's https://caddyserver.com/ to this list? (very much looking forward to trying ory out with Traefik on Docker Swarm - currently using Keycloak :)

aeneasr added a commit that referenced this issue Jul 29, 2020
Refactors the decisions API location from `/decisions` to `/decisions/traefik`.
Additionally, an endpoint `/decisions/traefik` has been added for integration with the Traefik proxy.

Closes #263

BREAKING CHANGE: Please update `/decisions` to `/decisions/generic` in all applications that use the ORY Oathkeeper Decisions API.
aeneasr added a commit that referenced this issue Jul 29, 2020
Refactors the decisions API location from `/decisions` to `/decisions/traefik`.
Additionally, an endpoint `/decisions/traefik` has been added for integration with the Traefik proxy.

Closes #263

BREAKING CHANGE: Please update `/decisions` to `/decisions/generic` in all applications that use the ORY Oathkeeper Decisions API.

Co-authored-by: Michiel Vanderlee <jmt.vanderlee@gmail.com>
@aeneasr aeneasr modified the milestones: v0.38.0, v0.39.0 Jul 29, 2020
@aeneasr aeneasr added help wanted We are looking for help on this one. and removed up for grab labels Aug 20, 2020
@tomiles
Copy link

tomiles commented Jun 24, 2021

I would love to use the changes part of #486. It has been merged in the next-gen branch.
But its unclear when this might find its way in the master or next release, any updates on that?
As a workaround untill then I can probably apply that PR onto the current master and build it myself?

@aeneasr
Copy link
Member

aeneasr commented Jun 24, 2021

We're currently looking for maintainers (as a full time job) for Ory Oathkeeper because we currently lack resources to implement these things internally.

aeneasr pushed a commit that referenced this issue Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working. help wanted We are looking for help on this one.
Projects
None yet
Development

No branches or pull requests

6 participants