From 1a306a24f4c2e164be32ef90aac0f506ff55c2be Mon Sep 17 00:00:00 2001 From: Lukas Krause Date: Mon, 21 Aug 2017 15:00:08 +0200 Subject: [PATCH] Fix uninitialized value error and typos --- lib/OpenQA/WebAPI/Controller/Main.pm | 2 +- templates/main/more_builds.html.ep | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/OpenQA/WebAPI/Controller/Main.pm b/lib/OpenQA/WebAPI/Controller/Main.pm index 4e523e51ad6..4d8b89f5e9d 100644 --- a/lib/OpenQA/WebAPI/Controller/Main.pm +++ b/lib/OpenQA/WebAPI/Controller/Main.pm @@ -89,7 +89,7 @@ sub group_overview { my $only_tagged = $self->param('only_tagged') // 0; my $group = $self->db->resultset($resultset)->find($self->param('groupid')); return $self->reply->not_found unless $group; - $self->stash('fullscreen', $self->param('fullscreen')); + $self->stash('fullscreen', $self->param('fullscreen') // 0); my @comments; my @pinned_comments; diff --git a/templates/main/more_builds.html.ep b/templates/main/more_builds.html.ep index 2075efd03b3..27ac325e764 100644 --- a/templates/main/more_builds.html.ep +++ b/templates/main/more_builds.html.ep @@ -8,11 +8,11 @@ %= b join(' / ', map { $_ eq $selected ? "$_" : link_to($_ => url_with->query([only_tagged => $tagged{$_}])) } reverse sort keys %tagged); -
+
Set mode to % if ($fullscreen == 0) { - <%= link_to url_for->query(fullscreen => 1)->to_abs => begin %>Full screen<% end %> + <%= link_to url_for->query(fullscreen => 1)->to_abs => begin %>full screen<% end %> % } else { - <%= link_to url_for->query(fullscreen => 0)->to_abs => begin %>Default view<% end %> + <%= link_to url_for->query(fullscreen => 0)->to_abs => begin %>default view<% end %> % }