Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix synchronization of TODO with badges #1234

Merged
merged 1 commit into from
Mar 7, 2017

Conversation

Martchus
Copy link
Contributor

  • First introduced with fe2fa2b
  • All softfails except ones with unreviewed failed modules
    are filtered out

See https://progress.opensuse.org/issues/17172

But we should discuss how to improve this in general, because that there are 2 different softfails is too confusing. Actually, I'm hoping to do the right thing this time.

qr/Passed: 0 Failed: 1/i,
'todo=1 shows all unlabeled failed and unlabeled softfailed with failing modules'
);
$t->element_exists_not('#res-99936', 'softfailed with reviwed failing module filtered out');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/reviwed/reviewed/

like(
get_summary,
qr/Passed: 0 Failed: 1/i,
'todo=1 shows all unlabeled failed and unlabeled softfailed with failing modules'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better update the comment to something like 'todo=1 shows only unlabeled left failed as softfailed with failing modules was labeled'

* First introduced with fe2fa2b
* All softfails except ones with unreviewed failed modules
  are filtered out

See https://progress.opensuse.org/issues/17172
@Martchus
Copy link
Contributor Author

Martchus commented Mar 2, 2017

Changed comment and fixed typo.

@okurz
Copy link
Member

okurz commented Mar 3, 2017

LGTM

@sysrich
Copy link
Member

sysrich commented Mar 3, 2017 via email

@Soulofdestiny
Copy link
Contributor

@okurz yeah, join us

@foursixnine
Copy link
Member

foursixnine commented Mar 3, 2017 via email

@okurz
Copy link
Member

okurz commented Mar 3, 2017

:-D actually, I am on a combat pause on the battlefield ;-)
arma3_2017_03_03_22_41_10_052

but it's nice you guys think of me :-)

@foursixnine
Copy link
Member

foursixnine commented Mar 3, 2017 via email

@okurz
Copy link
Member

okurz commented Mar 3, 2017

it's look you are putting together random combinations of words of the right vocabulary. They seem to make sense but ... don't. "optical experiment supplies", like ... colorful glasses?

@aaannz aaannz merged commit 7aeb590 into os-autoinst:master Mar 7, 2017
coolo pushed a commit that referenced this pull request Mar 7, 2017
commit 7aeb590
Merge: 9fb54f6 c8b45e8
Author:     Ondřej Holeček <oholecek@aaannz.eu>
AuthorDate: Tue Mar 7 15:10:37 2017 +0100
Commit:     GitHub <noreply@github.com>
CommitDate: Tue Mar 7 15:10:37 2017 +0100

    Merge pull request #1234 from Martchus/fix/todo

    Fix synchronization of TODO with badges
@Martchus Martchus deleted the fix/todo branch March 10, 2017 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants