action #2996 - ensure well formed json for needles #164
Conversation
|
test suite is broken |
| } | ||
| if (!exists $area->{'width'} ) { | ||
| $errorh{'message'}="area without width"; | ||
| return \%errorh; |
There was a problem hiding this comment.
Why are you returing hashref if you only use that for storing the string? Why not return the error message itself?
And it seems tidy did not catch this, but AFAIK we use spaces around = everywhere else.
There was a problem hiding this comment.
Idea was to return a richer structure, in the end the message was enough. Not really a problem as it is now, and allows easy extension if needed.
There was a problem hiding this comment.
Well it looks rather criptic and thus it is kind of problem for me. Can be easily changed to hashref if needed in the future. ;)
There was a problem hiding this comment.
well, if this is cryptic, I do not know how to call the rest of most of the openQA code... but ok, no problem to change it.
Conflicts: lib/OpenQA/Controller/Step.pm
|
LGTM |
action #2996 - ensure well formed json for needles
explicit hash checking via decode_json() import