Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Improve code for settings expansion" #2073

Merged
merged 1 commit into from
May 15, 2019
Merged

Revert "Improve code for settings expansion" #2073

merged 1 commit into from
May 15, 2019

Conversation

Martchus
Copy link
Contributor

Reverts #2057

@Martchus
Copy link
Contributor Author

@Amrysliu I'd say we remove the PR for now because the introduced regression has a too high impact. (We patches OSD but all private instances would be affected as well.)

@Martchus Martchus merged commit d98426e into master May 15, 2019
@Martchus Martchus deleted the revert-2057-improve_job_setting branch May 15, 2019 12:10
coolo pushed a commit that referenced this pull request May 15, 2019
Update documentation to commit d98426e
68c488b 
commit d98426e
Merge: 9935286 3904994
Author:     Martchus <martchus@gmx.net>
AuthorDate: Wed May 15 14:10:41 2019 +0200
Commit:     GitHub <noreply@github.com>
CommitDate: Wed May 15 14:10:41 2019 +0200

    Merge pull request #2073 from os-autoinst/revert-2057-improve_job_setting

    Revert "Improve code for settings expansion"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraih kraih kraih approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Martchus @kraih