Expose saving of YAML templates and hide the legacy UI#2111
Expose saving of YAML templates and hide the legacy UI#2111kalikiana merged 1 commit intoos-autoinst:masterfrom
Conversation
Martchus
left a comment
There was a problem hiding this comment.
The tests don't pass yet and I haven't tested it locally yet. But judging from the code it looks already good.
|
Could you deploy that to our staging instances? |
Codecov Report
@@ Coverage Diff @@
## master #2111 +/- ##
=========================================
+ Coverage 83.35% 83.46% +0.1%
=========================================
Files 170 170
Lines 10618 10626 +8
=========================================
+ Hits 8851 8869 +18
+ Misses 1767 1757 -10
Continue to review full report at Codecov.
|
|
Before we allow users to save YAML (and add parameters) dump_templates and load_templates should support them (or at least just ignore them). |
Codecov Report
@@ Coverage Diff @@
## master #2111 +/- ##
==========================================
- Coverage 85.92% 85.86% -0.07%
==========================================
Files 164 164
Lines 10803 10805 +2
==========================================
- Hits 9283 9278 -5
- Misses 1520 1527 +7
Continue to review full report at Codecov.
|
referencefeature (no diff here, just a simple error)Prerequisite: #2103
Fixes: poo#54146