Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose saving of YAML templates and hide the legacy UI #2111

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@kalikiana
Copy link
Contributor

commented Jun 17, 2019

  • Expose Save button in the UI
  • Hide legacy UI when YAML is/was stored
  • Handle conflicts via the reference feature (no diff here, just a simple error)

Screenshot from 2019-06-18 11-21-54

Prerequisite: #2103

Fixes: poo#54146

@kalikiana kalikiana requested review from kraih and Martchus Jun 17, 2019

@kalikiana kalikiana self-assigned this Jun 17, 2019

@Martchus
Copy link
Contributor

left a comment

The tests don't pass yet and I haven't tested it locally yet. But judging from the code it looks already good.

@kalikiana kalikiana force-pushed the kalikiana:yaml-store-ui branch from df8522e to a53bd03 Jun 17, 2019

@kalikiana kalikiana force-pushed the kalikiana:yaml-store-ui branch from a53bd03 to 41d95f0 Jun 18, 2019

@okurz

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

Could you deploy that to our staging instances?

@kalikiana kalikiana force-pushed the kalikiana:yaml-store-ui branch from 41d95f0 to 33c1b2d Jul 1, 2019

@kalikiana kalikiana closed this Jul 4, 2019

@kalikiana kalikiana force-pushed the kalikiana:yaml-store-ui branch from 33c1b2d to b06ecf3 Jul 4, 2019

@kalikiana kalikiana reopened this Jul 4, 2019

@kalikiana kalikiana changed the title Yaml store ui Expose saving of YAML templates and hiding the legacy UI Jul 4, 2019

@kalikiana kalikiana changed the title Expose saving of YAML templates and hiding the legacy UI Expose saving of YAML templates and hide the legacy UI Jul 4, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 4, 2019

Codecov Report

Merging #2111 into master will increase coverage by 0.1%.
The diff coverage is 95%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #2111     +/-   ##
=========================================
+ Coverage   83.35%   83.46%   +0.1%     
=========================================
  Files         170      170             
  Lines       10618    10626      +8     
=========================================
+ Hits         8851     8869     +18     
+ Misses       1767     1757     -10
Impacted Files Coverage Δ
lib/OpenQA/WebSockets/Controller/Worker.pm 98.19% <100%> (+0.85%) ⬆️
lib/OpenQA/WebAPI/Controller/API/V1/JobTemplate.pm 94% <94.73%> (+0.66%) ⬆️
lib/OpenQA/Scheduler/Model/Jobs.pm 88.88% <0%> (+2.77%) ⬆️
lib/OpenQA/WebSockets.pm 92.75% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b06ecf3...63277c4. Read the comment docs.

@Martchus

This comment has been minimized.

Copy link
Contributor

commented Jul 5, 2019

Before we allow users to save YAML (and add parameters) dump_templates and load_templates should support them (or at least just ignore them).

@kalikiana kalikiana force-pushed the kalikiana:yaml-store-ui branch from 63277c4 to 64c40f9 Jul 9, 2019

@kalikiana kalikiana force-pushed the kalikiana:yaml-store-ui branch from 64c40f9 to ed680a4 Jul 31, 2019

@codecov

This comment has been minimized.

Copy link

commented Jul 31, 2019

Codecov Report

Merging #2111 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2111      +/-   ##
==========================================
- Coverage   85.92%   85.86%   -0.07%     
==========================================
  Files         164      164              
  Lines       10803    10805       +2     
==========================================
- Hits         9283     9278       -5     
- Misses       1520     1527       +7
Impacted Files Coverage Δ
lib/OpenQA/WebAPI/Controller/API/V1/JobTemplate.pm 93.86% <100%> (+0.04%) ⬆️
lib/OpenQA/Worker/Settings.pm 84.31% <0%> (-13.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f154e1...ed680a4. Read the comment docs.

@okurz

okurz approved these changes Aug 1, 2019

@kalikiana kalikiana merged commit e7b2f56 into os-autoinst:master Aug 2, 2019

3 checks passed

codecov/patch 100% of diff hit (target 85.92%)
Details
codecov/project 85.86% (target 84.9%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.