Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all circleci test groups as convenience targets to Makefile #2799

Merged
merged 1 commit into from Mar 3, 2020

Conversation

@okurz
Copy link
Member

okurz commented Feb 29, 2020

No description provided.

@okurz okurz force-pushed the okurz:enhance/move_more_to_makefile branch from 4edf602 to a8a6f14 Feb 29, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 29, 2020

Codecov Report

Merging #2799 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2799      +/-   ##
=========================================
+ Coverage   92.02%   92.1%   +0.08%     
=========================================
  Files         190     190              
  Lines       11810   11810              
=========================================
+ Hits        10868   10878      +10     
+ Misses        942     932      -10
Impacted Files Coverage Δ
lib/OpenQA/Worker/Settings.pm 84.9% <0%> (-13.21%) ⬇️
lib/OpenQA/Scheduler/Model/Jobs.pm 91.49% <0%> (+2.83%) ⬆️
lib/OpenQA/Script.pm 85% <0%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe34bc...be80ae6. Read the comment docs.

@okurz okurz force-pushed the okurz:enhance/move_more_to_makefile branch from a8a6f14 to d7b0e56 Mar 2, 2020
@kraih
kraih approved these changes Mar 3, 2020
@okurz okurz force-pushed the okurz:enhance/move_more_to_makefile branch from d7b0e56 to be80ae6 Mar 3, 2020
Copy link
Contributor

kalikiana left a comment

Very nice!

@kalikiana kalikiana merged commit 8ead152 into os-autoinst:master Mar 3, 2020
14 checks passed
14 checks passed
OBS Package Build 8/8 processed
Details
ci/circleci: api Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: cache Your tests passed on CircleCI!
Details
ci/circleci: cache.fullstack Your tests passed on CircleCI!
Details
ci/circleci: checkstyle Your tests passed on CircleCI!
Details
ci/circleci: codecov Your tests passed on CircleCI!
Details
ci/circleci: developer Your tests passed on CircleCI!
Details
ci/circleci: fullstack Your tests passed on CircleCI!
Details
ci/circleci: scheduler Your tests passed on CircleCI!
Details
ci/circleci: t Your tests passed on CircleCI!
Details
ci/circleci: ui Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing cd27b6f...be80ae6
Details
codecov/project 92.1% (target 85.7%)
Details
@okurz okurz deleted the okurz:enhance/move_more_to_makefile branch Mar 3, 2020
@okurz

This comment has been minimized.

Copy link
Member Author

okurz commented Mar 3, 2020

For the sake of completeness, andriinikitin would favor to have no RETRY value set in the Makefile. We can still opt to set these values on any level of the stack. IMHO the current state is fine because tests are unstable regardless of circle CI environment even though maybe very hard to reproduce locally. If we encounter "circle CI only" sporadics of course we can set RETRY values only in .circleci/config.yml. The benefit with the current approach in this PR is that we do not need to spell out the test groups in the circleci config at all but just pass on the name as suffix. So if anyone wants to replicate the test setup e.g. in github actions or go back to travis CI that should be again easier :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.