Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent race condition when assigning and sending jobs to a worker #2839

Merged
merged 1 commit into from Mar 18, 2020

Conversation

@Martchus
Copy link
Contributor

Martchus commented Mar 16, 2020

This is an amendment for the original fix 74f4143. The original fix was not sufficient because it did not take into account that workers might be actually idling for a while. These status updates should not already count as first chance for the worker to process a job assignment.

This is an amendment for the original fix 74f4143. The original fix
was not sufficient because it did not take into account that workers
might be actually idling for a while. These status updates should
not already count as first chance for the worker to process a job
assignment.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #2839 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2839      +/-   ##
==========================================
+ Coverage   92.57%   92.59%   +0.02%     
==========================================
  Files         190      190              
  Lines       11871    11871              
==========================================
+ Hits        10989    10992       +3     
+ Misses        882      879       -3
Impacted Files Coverage Δ
lib/OpenQA/WebSockets/Controller/Worker.pm 96.72% <100%> (ø) ⬆️
lib/OpenQA/Worker/Job.pm 74.55% <0%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88254ac...6fda548. Read the comment docs.

@Martchus

This comment has been minimized.

Copy link
Contributor Author

Martchus commented Mar 18, 2020

Can we merge this? I'd like to progress with https://progress.opensuse.org/issues/62984.

@okurz
okurz approved these changes Mar 18, 2020
Copy link
Member

okurz left a comment

I don't understand the full concept. But the code changes look fine.

@Martchus Martchus merged commit 57dda54 into os-autoinst:master Mar 18, 2020
14 checks passed
14 checks passed
OBS Package Build 8/8 processed
Details
ci/circleci: api Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: cache Your tests passed on CircleCI!
Details
ci/circleci: cache.fullstack Your tests passed on CircleCI!
Details
ci/circleci: checkstyle Your tests passed on CircleCI!
Details
ci/circleci: codecov Your tests passed on CircleCI!
Details
ci/circleci: developer Your tests passed on CircleCI!
Details
ci/circleci: fullstack Your tests passed on CircleCI!
Details
ci/circleci: scheduler Your tests passed on CircleCI!
Details
ci/circleci: t Your tests passed on CircleCI!
Details
ci/circleci: ui Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 92.57%)
Details
codecov/project 92.59% (target 85.7%)
Details
@Martchus Martchus deleted the Martchus:fix-ws-race-condition branch Mar 18, 2020
@kraih
kraih approved these changes Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.