Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test client in OBS #2866

Merged
merged 4 commits into from Mar 25, 2020
Merged

Test client in OBS #2866

merged 4 commits into from Mar 25, 2020

Conversation

@perlpunk
Copy link
Contributor

perlpunk commented Mar 25, 2020

So we can test if the client package has all dependencies

  • Add openQA-client-test.spec
  • Add JSON::Validator, YAML::PP, YAML::XS to client_requires
  • Fix script/client to exit with 0 when called with --help

Currently testing in https://build.opensuse.org/package/show/home:tinita:branches:devel:openQA/openQA

@perlpunk perlpunk force-pushed the perlpunk:client-tests-obs branch from bbdad18 to e6f3a6b Mar 25, 2020
openQA-client-test.spec Outdated Show resolved Hide resolved
script/client Show resolved Hide resolved
openQA-client-test.spec Show resolved Hide resolved
openQA-client-test.spec Outdated Show resolved Hide resolved
perlpunk added 3 commits Mar 25, 2020
So we can test if the client package has all dependencies
We need a way to check if the script can be successfully loaded
@perlpunk perlpunk force-pushed the perlpunk:client-tests-obs branch from 3f431d5 to fb82dff Mar 25, 2020
@perlpunk

This comment has been minimized.

Copy link
Contributor Author

perlpunk commented Mar 25, 2020

I added "openQA-client-test" in https://build.opensuse.org/package/view_file/devel:openQA:TestGithub:PR-2866/openQA/_multibuild?expand=0&rev=f608cee80d0bf1de4aa5721b20564463 . The package shows up as "excluded" in https://build.opensuse.org/package/show/devel:openQA:TestGithub:PR-2866/openQA . let's see if it will be executed.

It also needs to be added in _service. I just did that.

Edit: I guess with every push changes get lost.

But it still looks good here: https://build.opensuse.org/package/show/home:tinita:branches:devel:openQA/openQA

t/40-openqa-clone-job.t Outdated Show resolved Hide resolved
@perlpunk perlpunk force-pushed the perlpunk:client-tests-obs branch from fb82dff to 16bf60d Mar 25, 2020
@okurz
okurz approved these changes Mar 25, 2020
@kraih
kraih approved these changes Mar 25, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #2866 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2866   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files         189      189           
  Lines       11882    11882           
=======================================
  Hits        11078    11078           
  Misses        804      804           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36618e3...16bf60d. Read the comment docs.

@okurz okurz merged commit 8bf743b into os-autoinst:master Mar 25, 2020
14 checks passed
14 checks passed
OBS Package Build 8/8 processed
Details
ci/circleci: api Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: cache Your tests passed on CircleCI!
Details
ci/circleci: cache.fullstack Your tests passed on CircleCI!
Details
ci/circleci: checkstyle Your tests passed on CircleCI!
Details
ci/circleci: codecov Your tests passed on CircleCI!
Details
ci/circleci: developer Your tests passed on CircleCI!
Details
ci/circleci: fullstack Your tests passed on CircleCI!
Details
ci/circleci: scheduler Your tests passed on CircleCI!
Details
ci/circleci: t Your tests passed on CircleCI!
Details
ci/circleci: ui Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 36618e3...16bf60d
Details
codecov/project 93.23% (target 85.70%)
Details
@perlpunk perlpunk deleted the perlpunk:client-tests-obs branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.