Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic phrase to 'died' reason if there's no more information #3359

Merged
merged 1 commit into from Sep 3, 2020

Conversation

Martchus
Copy link
Contributor

@Martchus Martchus commented Sep 3, 2020

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #3359 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3359      +/-   ##
==========================================
- Coverage   91.66%   91.65%   -0.02%     
==========================================
  Files         216      216              
  Lines       13198    13199       +1     
==========================================
- Hits        12098    12097       -1     
- Misses       1100     1102       +2     
Impacted Files Coverage Δ
lib/OpenQA/Worker/Job.pm 74.52% <100.00%> (+0.04%) ⬆️
lib/OpenQA/Scheduler/Model/Jobs.pm 93.06% <0.00%> (-0.41%) ⬇️
lib/OpenQA/WebAPI/Plugin/Helpers.pm 95.51% <0.00%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7017698...d825180. Read the comment docs.

@mergify mergify bot merged commit 074365e into os-autoinst:master Sep 3, 2020
@Martchus Martchus deleted the died branch September 3, 2020 20:22
@okurz
Copy link
Member

okurz commented Sep 4, 2020

these are the cases where I think mergify really helps. Two persons approved and only 3h later circle CI had again enough capacity to finish tests. Only the branch deletion is left. If everyone agrees then we can ask mergify to also delete all merged feature branches automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants