Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider finalize jobs successful if the openQA job does not exist #3550

Merged
merged 1 commit into from Nov 13, 2020

Conversation

Martchus
Copy link
Contributor

The openQA job likely just has been removed. Removing an openQA job
while the finalize Minion job is being executed would still screw
things up.

See https://progress.opensuse.org/issues/75073

The openQA job likely just has been removed. Removing an openQA job
while the finalize Minion job is being executed would still screw
things up.

See https://progress.opensuse.org/issues/75073
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #3550 (2099570) into master (39968b0) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3550      +/-   ##
==========================================
- Coverage   95.60%   95.57%   -0.04%     
==========================================
  Files         366      366              
  Lines       31764    31767       +3     
==========================================
- Hits        30368    30360       -8     
- Misses       1396     1407      +11     
Impacted Files Coverage Δ
lib/OpenQA/Task/Job/FinalizeResults.pm 100.00% <100.00%> (ø)
t/14-grutasks.t 100.00% <100.00%> (ø)
t/lib/OpenQA/Test/Utils.pm 65.24% <0.00%> (-3.71%) ⬇️
t/05-scheduler-full.t 97.43% <0.00%> (-0.52%) ⬇️
t/34-developer_mode-unit.t 100.00% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39968b0...2099570. Read the comment docs.

@Martchus Martchus merged commit 88ace70 into os-autoinst:master Nov 13, 2020
@Martchus Martchus deleted the finalize-job branch November 13, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants