Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger cleanup task when jobs are done #4181

Closed
wants to merge 1 commit into from

Conversation

kalikiana
Copy link
Member

@kalikiana kalikiana marked this pull request as ready for review September 9, 2021 07:07
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #4181 (a577b5d) into master (397f02b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4181   +/-   ##
=======================================
  Coverage   97.89%   97.90%           
=======================================
  Files         371      371           
  Lines       33335    33349   +14     
=======================================
+ Hits        32634    32649   +15     
+ Misses        701      700    -1     
Impacted Files Coverage Δ
lib/OpenQA/Setup.pm 98.44% <ø> (ø)
t/config.t 100.00% <ø> (ø)
lib/OpenQA/Task/Job/FinalizeResults.pm 100.00% <100.00%> (ø)
t/42-df-based-cleanup.t 100.00% <100.00%> (ø)
t/lib/OpenQA/Test/Utils.pm 82.52% <0.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 397f02b...a577b5d. Read the comment docs.

@@ -161,6 +161,7 @@ blocklist = job_grab job_done
#untracked_assets_storage_duration = 14
# Performs the cleanup of results/assets only if the free disk space on the relevant partition is below the specified percentage (and aborts early otherwise)
#result_cleanup_max_free_percentage = 100
#trigger_cleanup_on_job_done = 0
Copy link
Contributor

@Martchus Martchus Sep 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be in the middle of result_cleanup_max_free_percentage and asset_cleanup_max_free_percentage. It would make sense to put trigger_cleanup_on_job_done under its own explaining comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants