Add more query parameters for configuring last builds #575
Conversation
okurz
commented
Feb 25, 2016
okurz
commented
- Add optional query parameters to configure builds limit
- t: Delete dead code
- Add optional query parameters for showing previous builds
| @@ -24,7 +24,9 @@ use OpenQA::Schema::Result::Jobs; | |||
| sub _group_result { | |||
| my ($self, $group, $limit) = @_; | |||
|
|
|||
| my $timecond = {">" => time2str('%Y-%m-%d %H:%M:%S', time - 24 * 3600 * 14, 'UTC')}; | |||
| my $time_limit_days = $self->param('time_limit_days') // 14; | |||
There was a problem hiding this comment.
Looking at it, param validation is something we are long overdue. Would Mojo recovers when you supply i.e. text instead of \d+?
There was a problem hiding this comment.
Sometimes you can really think around corners and ask about weird unusual cases. I like that :-)
Calling http://localhost:9526/group_overview/1?time_limit_days=foo renders an empty page and the log output:
[00][Thu Feb 25 11:44:16 2016] [debug] GET "/group_overview/1"
[00][Thu Feb 25 11:44:16 2016] [debug] Routing to controller "OpenQA::WebAPI::Controller::Main" and action "group_overview"
[00][Thu Feb 25 11:44:16 2016] [debug] Retrieving results for up to 10 builds up to foo days old
[00]Argument "foo" isn't numeric in multiplication (*) at
[00] /home/okurz/local/os-autoinst/openQA/script/../lib/OpenQA/WebAPI/Controller/Main.pm line 29 (#1)
[00] (W numeric) The indicated string was fed as an argument to an operator
[00] that expected a numeric value instead. If you're fortunate the message
[00] will identify which operator was so unfortunate.
[00]
[00][Thu Feb 25 11:44:16 2016] [debug] Rendering cached template "main/group_overview.html.ep"
[00][Thu Feb 25 11:44:16 2016] [debug] Rendering cached template "layouts/info.html.ep"
[00][Thu Feb 25 11:44:16 2016] [debug] Rendering cached template "main/group_builds.html.ep"
[00][Thu Feb 25 11:44:16 2016] [debug] Rendering cached template "layouts/bootstrap.html.ep"
[00][Thu Feb 25 11:44:16 2016] [debug] Rendering cached template "branding/openSUSE/navbar.html.ep"
[00][Thu Feb 25 11:44:16 2016] [debug] 200 OK (0.014780s, 67.659/s)
So I would not over-engineer something here. As long as it is only used as a URL parameter I would not really invest more time in checking this more, an empty page should be good enough. If we would provide something like a search field this would invite also "unexperienced" users to type something and we should catch bad user input. agreed?
There was a problem hiding this comment.
Agree, I was only curious. Sometimes when script dies in Mojo controller it doesn't run that code anymore until restarted. I was worried being it this problem, but looks like it survived.
|
LGTM |
The index dashboard and group overview page limit the number of previous
builds based on hardcoded numbers. Adding query parameters this is easily
adjustable e.g. if one wants to get an overview of a longer history.
Example to show up to three week old builds instead of the default two weeks
with up to 20 builds instead of up to 10 being the default for the group
overview page:
http://openqa/group_overview/1?time_limit_days=21&limit_builds=20
$driver has "find_element(<tag>, 'css')" which is doing the equivalent of "find_element_by_css(<tag>)" so why keep the "TODO" around?
Replace hardcoded number of 500 with the optional query parameter with keeping 500 as a default. Higher numbers would yield more complex database queries but can be selected for special investigation use cases with the advanced query parameters.
okurz
force-pushed
the
feature/more_query_overwrite
branch
from
8113924
to
850d535
Compare
Add more query parameters for configuring last builds
|
Just as a future note: later I'm for to add limit to |
|
exactly the thing I am working on right now :-) |
|
ok, not exactly what I am working on as I don't know what a good value would be |
