t: Avoid tampering with git checkout #5857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
approved these changes
Aug 14, 2024
Martchus
reviewed
Aug 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5857 +/- ##
=======================================
Coverage 98.50% 98.50%
=======================================
Files 395 395
Lines 38753 38759 +6
=======================================
+ Hits 38174 38180 +6
Misses 579 579 ☔ View full report in Codecov by Sentry. |
I was running this test locally and it failed every second time, because it created some directory that wasn't cleaned up. Now it copies everything it needs to a tempdir and leaves the source dir alone. Related issue: https://progress.opensuse.org/issues/164883
If the number changes, one often forgets to update the test label as well
Martchus
approved these changes
Aug 14, 2024
os-autoinst-bot
pushed a commit
to os-autoinst-bot/openQA
that referenced
this pull request
Aug 15, 2024
commit b24c267 Merge: 3f88197 6fb2c48 Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> AuthorDate: Wed Aug 14 18:34:45 2024 +0000 Commit: GitHub <noreply@github.com> CommitDate: Wed Aug 14 18:34:45 2024 +0000 Merge pull request os-autoinst#5857 from perlpunk/tempdir t: Avoid tampering with git checkout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running this test locally and it failed every second time, because it created some directory that wasn't cleaned up.
Now it copies everything it needs to a tempdir and leaves the source dir alone.
Related issue: https://progress.opensuse.org/issues/164883