Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish product and test issues bugref #708

Merged
merged 1 commit into from Jun 6, 2016

Conversation

Projects
None yet
4 participants
@okurz
Copy link
Member

commented Jun 6, 2016

Progress is used to track test issues, bugzilla for product issues, at least
for SUSE/openSUSE. This might be a lot different for other groups so a more
flexible approach could be thought of but probably it is not as easy as
just distinguishing on the issue tracker URL being used, e.g. if a group
uses just one issue tracker but different components or issue types to
differentiate, it is not that easy. That is why this simple solution is
done here, first. At least others can follow the approach and have a test
and CSS rule available ;-)

Example screenshot:
openqa_bolt_icon_for_progress_issue

Alternative 1: Inverted bug icon, vote for this, if you like it more than what has been currently implemented:
openqa_inverted_red_bug_for_progress_issue

@@ -4,7 +4,7 @@
% if ($bug) {
<span id="bug-<%= $jobid %>">
<a href="<%= bugurl_for $bug %>">
<i class="test-label label_bug fa fa-bug" title="Bug(s) referenced: <%= $bug %>"></i>
<i class="test-label label_bug fa <%= $bug =~ /poo#/ ? 'fa-bolt' : 'fa-bug' %>" title="Bug(s) referenced: <%= $bug %>"></i>

This comment has been minimized.

Copy link
@coolo

coolo Jun 6, 2016

Contributor

I suggest to move that code into a helper

This comment has been minimized.

Copy link
@okurz

okurz Jun 6, 2016

Author Member

will do, code update is not related. Need to rebase anyway, I guess

@okurz okurz force-pushed the okurz:feature/poo_icon branch from 0aa9208 to 869ec10 Jun 6, 2016

Distinguish product and test issues bugref
Progress is used to track test issues, bugzilla for product issues, at least
for SUSE/openSUSE. This might be a lot different for other groups so a more
flexible approach could be thought of but probably it is not as easy as
just distinguishing on the issue tracker URL being used, e.g. if a group
uses just one issue tracker but different components or issue types to
differentiate, it is not that easy. That is why this simple solution is
done here, first. At least others can follow the approach and have a test
and CSS rule available ;-)

@okurz okurz force-pushed the okurz:feature/poo_icon branch from 869ec10 to a80a5bb Jun 6, 2016

@okurz

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2016

updated:

  • rebased
  • add helper bugicon_for
@sysrich

This comment has been minimized.

Copy link
Member

commented Jun 6, 2016

I prefer the lightning bolt than the upside down bug

@okurz

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2016

good, then nothing needs to be changed :-)

@coveralls

This comment has been minimized.

Copy link

commented Jun 6, 2016

Coverage Status

Coverage increased (+0.02%) to 65.959% when pulling a80a5bb on okurz:feature/poo_icon into d758ad0 on os-autoinst:master.

@coveralls

This comment has been minimized.

Copy link

commented Jun 6, 2016

Coverage Status

Coverage remained the same at 65.936% when pulling 869ec10 on okurz:feature/poo_icon into d758ad0 on os-autoinst:master.

@coolo coolo merged commit 510d499 into os-autoinst:master Jun 6, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@okurz okurz deleted the okurz:feature/poo_icon branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.