Distinguish product and test issues bugref #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,7 +4,7 @@ | |||
| % if ($bug) { | |||
| <span id="bug-<%= $jobid %>"> | |||
| <a href="<%= bugurl_for $bug %>"> | |||
| <i class="test-label label_bug fa fa-bug" title="Bug(s) referenced: <%= $bug %>"></i> | |||
| <i class="test-label label_bug fa <%= $bug =~ /poo#/ ? 'fa-bolt' : 'fa-bug' %>" title="Bug(s) referenced: <%= $bug %>"></i> | |||
There was a problem hiding this comment.
I suggest to move that code into a helper
There was a problem hiding this comment.
will do, code update is not related. Need to rebase anyway, I guess
Progress is used to track test issues, bugzilla for product issues, at least for SUSE/openSUSE. This might be a lot different for other groups so a more flexible approach could be thought of but probably it is not as easy as just distinguishing on the issue tracker URL being used, e.g. if a group uses just one issue tracker but different components or issue types to differentiate, it is not that easy. That is why this simple solution is done here, first. At least others can follow the approach and have a test and CSS rule available ;-)
|
updated:
|
|
I prefer the lightning bolt than the upside down bug |
|
good, then nothing needs to be changed :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress is used to track test issues, bugzilla for product issues, at least
for SUSE/openSUSE. This might be a lot different for other groups so a more
flexible approach could be thought of but probably it is not as easy as
just distinguishing on the issue tracker URL being used, e.g. if a group
uses just one issue tracker but different components or issue types to
differentiate, it is not that easy. That is why this simple solution is
done here, first. At least others can follow the approach and have a test
and CSS rule available ;-)
Example screenshot:
Alternative 1: Inverted bug icon, vote for this, if you like it more than what has been currently implemented:
