Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web UI controls to select more builds in group_overview #804

Merged
merged 1 commit into from Aug 8, 2016

Conversation

Projects
None yet
3 participants
@okurz
Copy link
Member

commented Jul 31, 2016

The query parameter 'limit_builds' allows to show more than the default 10
builds on demand. Just like we have for configuring previous results, the
current commit adds web UI selections to reload the same page with
higher number of builds on demand. For this, the limit of days is increased
to show more builds but still limited by the selected number.

Example screenshot:
openqa_limit_builds_current_bold

@coolo

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2016

I don't like this 'limited to 3' - this appears to me like a feature to ease test writing, but not necessarily adding anything useful for the user

@okurz

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2016

We have the same information for previous results. I thought it would be useful e.g. in the case when there are only 2 builds at all but it says "limited to 10" so users should understand it wouldn't help to click "400 builds".

@okurz okurz force-pushed the okurz:feature/more_builds_gui branch from 137a190 to 3da2b1c Aug 1, 2016

@coveralls

This comment has been minimized.

Copy link

commented Aug 1, 2016

Coverage Status

Changes Unknown when pulling 3da2b1c on okurz:feature/more_builds_gui into * on os-autoinst:master*.

@coolo

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2016

this is very easy to find out yourself, you don't need the UI to babysit you. You don't put "(this is the group name)" behind Tumbleweed just in case someone confuses it with the real Tumbleweed.

@okurz

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2016

It's not easy to find out because if the URL is
http://openqa/group_overview/1 nobody knows that by default it's limiting to 10 builds unless you read the source code.

@coolo

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2016

then make 10 a valid option in your list and highlight the currently selected option - once again pointing you to the solution used everywhere else in our application: https://datatables.net/examples/styling/bootstrap.html

@okurz

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2016

you mean I should add a pull down menue and dynamically reload the page with different query parameters based on selection within the pull down menue? What we used "everywhere else" is to control the display of the already loaded table entries, isn't it?

@coolo

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2016

Noone stops you making it AJAX in a 2nd step

@okurz

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2016

On Monday 01 August 2016 04:10:16 Stephan Kulow wrote:

Noone stops you making it AJAX in a 2nd step

No one stops me but my lack of ajax knowledge certainly slows me down

@coolo

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2016

That's why they call you Mister Fahrenheit

@okurz

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2016

how very kind of you. But I wanted to keep the page clean and easy just as for previous results. Isn't that where modern page design goes and that's why we have mojo? Generate pages rather than loading complicate ones that try to do everything dynamically?

@coolo

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2016

No, the modern people combine nodejs with https://angularjs.org/ :)

@okurz

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2016

oh, and also by using direct links I am saving users one click.

@coolo

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2016

that will sum up easily to 2-3 seconds a life time for advanced users :)

@okurz okurz force-pushed the okurz:feature/more_builds_gui branch from 3da2b1c to 3d3f6f3 Aug 7, 2016

@okurz

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2016

Old screenshot:
openqa_limit_builds

updated to use the same approach as in #811: Show current limit in bold as part of the selection list

@coveralls

This comment has been minimized.

Copy link

commented Aug 7, 2016

Coverage Status

Coverage decreased (-0.06%) to 70.762% when pulling 3d3f6f3 on okurz:feature/more_builds_gui into d3dc0bc on os-autoinst:master.

@@ -242,6 +242,20 @@ sub register {

return $c->tag('span', title => $text, sub { substr($text, 0, $length - 4) . " ..." });
});

$app->helper(
#%= b join(' / ', map { link_to($_ == $limit_builds ? "<b>$_</b>" : $_ => url_with->query(time_limit_days => 1000, limit_builds => $_)) } (10, 20, 50, 100, 400))

This comment has been minimized.

Copy link
@coolo

coolo Aug 7, 2016

Contributor

you leave comments?

<div id="more_builds">
Limit to
%= b join(' / ', map { $_ == $limit_builds ? "<b>$_</b>" : link_to($_ => url_with->query(time_limit_days => 1000, limit_builds => $_)) } (10, 20, 50, 100, 400));
<!--%= limit_choices {limit_key => 'limit_builds', limit_builds => $limit_builds, query_args => {time_limit_days => 1000}}-->

This comment has been minimized.

Copy link
@coolo

coolo Aug 7, 2016

Contributor

even HTML comments?

This comment has been minimized.

Copy link
@okurz

okurz Aug 7, 2016

Author Member

I am soo … weekend?

Add web UI controls to select more builds in group_overview
The query parameter 'limit_builds' allows to show more than the default 10
builds on demand. Just like we have for configuring previous results, the
current commit adds web UI selections to reload the same page with
higher number of builds on demand. For this, the limit of days is increased
to show more builds but still limited by the selected number.

@okurz okurz force-pushed the okurz:feature/more_builds_gui branch from 3d3f6f3 to a9ac764 Aug 7, 2016

@okurz

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2016

updated:

  • removed WIP idea for plugin
  • removed disabled code
@coveralls

This comment has been minimized.

Copy link

commented Aug 7, 2016

Coverage Status

Coverage increased (+0.005%) to 70.83% when pulling a9ac764 on okurz:feature/more_builds_gui into 9d1a4b3 on os-autoinst:master.

@coolo coolo merged commit a9ac764 into os-autoinst:master Aug 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@okurz okurz deleted the okurz:feature/more_builds_gui branch Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.