Add web UI controls to filter only tagged or all builds #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -159,6 +160,14 @@ sub group_overview { | |||
| $res->{$build}->{tag} = {type => $tag[1], description => $tag[2]}; | |||
| } | |||
| } | |||
| if ($only_tagged) { | |||
| for my $build (keys %$res) { | |||
| print "\$build: $build\n"; | |||
There was a problem hiding this comment.
This is debug print only, right?
|
@coolo tell me if you want to use this current version or wait for me learn angularjs :-) |
okurz
force-pushed
the
feature/more_builds_gui_only_tagged
branch
from
fb447d3
to
d814b93
Compare
|
but won't users be confused if they click 'show 400 builds' and they only get 50? :) |
|
:-D yes, they wil be |
The query parameter 'limit_builds' allows to show more than the default 10 builds on demand. Just like we have for configuring previous results, the current commit adds web UI selections to reload the same page with higher number of builds on demand. For this, the limit of days is increased to show more builds but still limited by the selected number.
Using a new query parameter 'only_tagged=[0|1]' the list can be filtered. Related progress issue: https://progress.opensuse.org/issues/11052
okurz
force-pushed
the
feature/more_builds_gui_only_tagged
branch
from
d814b93
to
07220d7
Compare
|
updated:
old screenshot: new screenshot updated in description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a new query parameter 'only_tagged=[0|1]' the list can be filtered.
Example screenshot:
Related progress issue: https://progress.opensuse.org/issues/11052
Obsoletes #804