Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web UI controls to filter only tagged or all builds #807

Merged
merged 2 commits into from Aug 8, 2016

Conversation

@okurz
Copy link
Member

@okurz okurz commented Aug 1, 2016

Using a new query parameter 'only_tagged=[0|1]' the list can be filtered.

Example screenshot:
openqa_limit_builds_current_bold_and_only_tagged

Related progress issue: https://progress.opensuse.org/issues/11052

Obsoletes #804

@@ -159,6 +160,14 @@ sub group_overview {
$res->{$build}->{tag} = {type => $tag[1], description => $tag[2]};
}
}
if ($only_tagged) {
for my $build (keys %$res) {
print "\$build: $build\n";
Copy link
Member

@aaannz aaannz Aug 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is debug print only, right?

Loading

Copy link
Member Author

@okurz okurz Aug 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, fixed, thx.

Loading

@okurz
Copy link
Member Author

@okurz okurz commented Aug 1, 2016

@coolo tell me if you want to use this current version or wait for me learn angularjs :-)

Loading

@okurz okurz force-pushed the feature/more_builds_gui_only_tagged branch from fb447d3 to d814b93 Aug 1, 2016
@coolo
Copy link
Contributor

@coolo coolo commented Aug 1, 2016

but won't users be confused if they click 'show 400 builds' and they only get 50? :)

Loading

@okurz
Copy link
Member Author

@okurz okurz commented Aug 1, 2016

:-D yes, they wil be

Loading

@coveralls
Copy link

@coveralls coveralls commented Aug 1, 2016

Coverage Status

Coverage increased (+0.03%) to 70.392% when pulling d814b93 on okurz:feature/more_builds_gui_only_tagged into e4400c7 on os-autoinst:master.

Loading

okurz added 2 commits Aug 7, 2016
The query parameter 'limit_builds' allows to show more than the default 10
builds on demand. Just like we have for configuring previous results, the
current commit adds web UI selections to reload the same page with
higher number of builds on demand. For this, the limit of days is increased
to show more builds but still limited by the selected number.
Using a new query parameter 'only_tagged=[0|1]' the list can be filtered.

Related progress issue: https://progress.opensuse.org/issues/11052
@okurz okurz force-pushed the feature/more_builds_gui_only_tagged branch from d814b93 to 07220d7 Aug 7, 2016
@okurz
Copy link
Member Author

@okurz okurz commented Aug 7, 2016

updated:

  • rebased on current #804 and adapted to also show current selection in list in bold, non-link

old screenshot:
openqa_show_only_tagged_builds

new screenshot updated in description

Loading

@coveralls
Copy link

@coveralls coveralls commented Aug 7, 2016

Coverage Status

Coverage increased (+0.04%) to 70.865% when pulling 07220d7 on okurz:feature/more_builds_gui_only_tagged into 9d1a4b3 on os-autoinst:master.

Loading

@coolo coolo merged commit d8fe6a7 into os-autoinst:master Aug 8, 2016
1 check passed
Loading
@okurz okurz deleted the feature/more_builds_gui_only_tagged branch Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants