Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to latest in scenario name #836

Merged

Conversation

Projects
None yet
4 participants
@okurz
Copy link
Member

commented Aug 20, 2016

Screenshot:
openqa_link_to_latest_in_previous

Add link to latest job in each scenario
Based on 'latest' query route each job can now link to the
newest incarnation within in the same scenario.
@coveralls

This comment has been minimized.

Copy link

commented Aug 20, 2016

Coverage Status

Coverage increased (+0.005%) to 71.03% when pulling 13199c2 on okurz:feature/link_to_latest_in_scenario_name into bc7a31d on os-autoinst:master.

@okurz okurz force-pushed the okurz:feature/link_to_latest_in_scenario_name branch from 13199c2 to 3a2842b Aug 24, 2016

@coveralls

This comment has been minimized.

Copy link

commented Aug 24, 2016

Coverage Status

Coverage increased (+0.005%) to 71.054% when pulling 3a2842b on okurz:feature/link_to_latest_in_scenario_name into 3e440e8 on os-autoinst:master.

@@ -1,5 +1,5 @@
<div id="scenario">
<div class="h5">Results for <i><%= $scenario %></i></div>
<div class="h5">Results for <i><%= link_to($scenario => url_for ('latest')->query($job->scenario_hash)) %></i></div>

This comment has been minimized.

Copy link
@aaannz

aaannz Aug 26, 2016

Member

Tried it and it's confusing for me. I would prefer something like:

<div class="h5">Results for <i><%= $scenario %></i> (<%= link_to('latest results for this scenario' => url_for('latest')->query($job->scenario_hash)) %>)</div>

This comment has been minimized.

Copy link
@okurz

okurz Aug 26, 2016

Author Member

On Friday 26 August 2016 07:26:07 Ondřej Holeček wrote:

@@ -1,5 +1,5 @@

-
Results for <%= $scenario %>
-
Results for <%= link_to($scenario => url_for ('latest')->query($job->scenario_hash)) %>
Tried it and it's confusing for me. I would prefer something like:
<div class="h5">Results for <i><%= $scenario %></i> (<%= link_to('latest
results for this scenario' =>
url_for('latest')->query($job->scenario_hash)) %>)</div> ```

sure, I wouldn't mind

This comment has been minimized.

Copy link
@coolo

coolo Sep 1, 2016

Contributor

latest results implies it's multiple results, but it's just one -> 'latest job' then

@okurz

This comment has been minimized.

Copy link
Member Author

commented Aug 31, 2016

updated:

  • made link more explicit as suggested by @aaannz
  • added screenshot to description

@coolo your opinion?

@coolo

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2016

other than the wording I'm fine with the change

@okurz okurz force-pushed the okurz:feature/link_to_latest_in_scenario_name branch from cceb92f to e54f550 Sep 1, 2016

@okurz

This comment has been minimized.

Copy link
Member Author

commented Sep 1, 2016

@okurz okurz force-pushed the okurz:feature/link_to_latest_in_scenario_name branch from e54f550 to 70c5c83 Sep 1, 2016

@okurz

This comment has been minimized.

Copy link
Member Author

commented Sep 1, 2016

@coolo, @aaannz updated wording, just using regex match for the test to not replicate the full text content and confuse trim_whitespace. Please merge and deploy, should make anyone happy asking in bugs: "Does this still happen?" ;-)

@aaannz

This comment has been minimized.

Copy link
Member

commented Sep 1, 2016

I don't know, trim_whitespace replace multiple spaces by one and removes spaces at the beginning and end of the string. From my limited perspective it seems to me you wanted to remove one space near () inside of the string.

@aaannz

This comment has been minimized.

Copy link
Member

commented Sep 1, 2016

btw. LGTM :)

@coveralls

This comment has been minimized.

Copy link

commented Sep 1, 2016

Coverage Status

Coverage increased (+0.005%) to 70.994% when pulling 70c5c83 on okurz:feature/link_to_latest_in_scenario_name into 8609e09 on os-autoinst:master.

@okurz

This comment has been minimized.

Copy link
Member Author

commented Sep 1, 2016

@aaannz aaannz merged commit 132350b into os-autoinst:master Sep 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@okurz okurz deleted the okurz:feature/link_to_latest_in_scenario_name branch Sep 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.