Link to latest in scenario name

[okurz]

Screenshot:

[coveralls]

Coverage increased (+0.005%) to 71.03% when pulling 13199c2 on okurz:feature/link_to_latest_in_scenario_name into bc7a31d on os-autoinst:master.

[coveralls]

Coverage increased (+0.005%) to 71.054% when pulling 3a2842b on okurz:feature/link_to_latest_in_scenario_name into 3e440e8 on os-autoinst:master.

[aaannz]

Tried it and it's confusing for me. I would prefer something like:

<div class="h5">Results for <i><%= $scenario %></i> (<%= link_to('latest results for this scenario' => url_for('latest')->query($job->scenario_hash)) %>)</div>

[okurz]

On Friday 26 August 2016 07:26:07 Ondřej Holeček wrote:

@@ -1,5 +1,5 @@

-

Results for <%= $scenario %>

-

Results for <%= link_to($scenario => url_for ('latest')->query($job->scenario_hash)) %>

Tried it and it's confusing for me. I would prefer something like:

<div class="h5">Results for <i><%= $scenario %></i> (<%= link_to('latest
results for this scenario' =>
url_for('latest')->query($job->scenario_hash)) %>)</div> ```

sure, I wouldn't mind

[coolo]

latest results implies it's multiple results, but it's just one -> 'latest job' then

[okurz]

updated:

• made link more explicit as suggested by @aaannz
• added screenshot to description

@coolo your opinion?

[coolo]

other than the wording I'm fine with the change

[okurz]

@aaannz the trim_whitespace failed me in https://travis-ci.org/os-autoinst/openQA/builds/156827974

[okurz]

@coolo, @aaannz updated wording, just using regex match for the test to not replicate the full text content and confuse trim_whitespace. Please merge and deploy, should make anyone happy asking in bugs: "Does this still happen?" ;-)

[aaannz]

I don't know, trim_whitespace replace multiple spaces by one and removes spaces at the beginning and end of the string. From my limited perspective it seems to me you wanted to remove one space near () inside of the string.

[aaannz]

btw. LGTM :)

[coveralls]

Coverage increased (+0.005%) to 70.994% when pulling 70c5c83 on okurz:feature/link_to_latest_in_scenario_name into 8609e09 on os-autoinst:master.

[okurz]

@coolo was fine with the change, name is fixed, want to merge?