Add support for github 'bugrefs' #973
Merged
Conversation
t/16-utils.t
Outdated
| use Test::More; | ||
| use Test::Mojo; | ||
| use Test::Warnings; | ||
| use Test::Output qw/stderr_like/; |
Martchus
Oct 31, 2016
Contributor
This is probably not required.
But it might make sense to merge this file with 16-utils-runcmd.t anyways.
This is probably not required.
But it might make sense to merge this file with 16-utils-runcmd.t anyways.
okurz
Oct 31, 2016
Author
Member
Thanks. Deleted unused uses. But I don't want to merge with 16-utils-runcmd.t which loads the database and is therefore way slower than 16-utils.t which is only using the functions which don't need the database and is near instantly finished.
Thanks. Deleted unused uses. But I don't want to merge with 16-utils-runcmd.t which loads the database and is therefore way slower than 16-utils.t which is only using the functions which don't need the database and is near instantly finished.
lib/OpenQA/Utils.pm
Outdated
| ); | ||
| my %bugurls = ( | ||
| 'https://bugzilla.novell.com/show_bug.cgi?id=' => 'bsc', | ||
| $bugrefs{bsc} => 'bsc', | ||
| $bugrefs{boo} => 'boo', | ||
| $bugrefs{poo} => 'poo', | ||
| 'https://github.com/' => 'gh', |
aaannz
Nov 1, 2016
Member
Just wondering why you didn't use $bugrefs{gh}?
Just wondering why you didn't use $bugrefs{gh}?
okurz
Nov 1, 2016
Author
Member
probably it differed during my development but does not anymore now. I will correct.
probably it differed during my development but does not anymore now. I will correct.
Add support for generic github repo markers as 'bugrefs Using the generic profile '<marker>[#<project/repo>]#<id>' for all bugrefs, especially for github, allows to track all issues reported on github and especially test fixing pull requests to be recorded as 'bugrefs' with the same icon as for "test issues", i.e. poo#. This way there is no need to create a ticket just to track a test issue for which already a github pull request exist because otherwise the URL to the github PR would not mean anything special to github and therefore not mark a job as "labeled". Also, pasting full github URLs is supported, same as for all other bugrefs, meaning that the URL is abbreviated into short form bugrefs. The pattern follows the openSUSE/OBS recommendation.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Add support for generic github repo markers as 'bugrefs
Using the generic profile
'[#<project/repo>]#'
for all bugrefs, especially for github, allows to
track all issues reported on github and especially
test fixing pull requests to be recorded as 'bugrefs'
with the same icon as for "test issues", i.e. poo#.
This way there is no need to create a ticket just
to track a test issue for which already a github
pull request exist because otherwise the URL to the
github PR would not mean anything special to github
and therefore not mark a job as "labeled".
Also, pasting full github URLs is supported, same as
for all other bugrefs, meaning that the URL is
abbreviated into short form bugrefs.
The pattern follows the openSUSE/OBS recommendation.