Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
okurz
force-pushed the
okurz:feature/gh_marker
branch
from
18869bf
to
a705315
Oct 29, 2016
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Oct 29, 2016
t/16-utils.t
Outdated
| use Test::More; | ||
| use Test::Mojo; | ||
| use Test::Warnings; | ||
| use Test::Output qw/stderr_like/; |
This comment has been minimized.
This comment has been minimized.
Martchus
Oct 31, 2016
Contributor
This is probably not required.
But it might make sense to merge this file with 16-utils-runcmd.t anyways.
This comment has been minimized.
This comment has been minimized.
okurz
Oct 31, 2016
Member
Thanks. Deleted unused uses. But I don't want to merge with 16-utils-runcmd.t which loads the database and is therefore way slower than 16-utils.t which is only using the functions which don't need the database and is near instantly finished.
okurz
force-pushed the
okurz:feature/gh_marker
branch
from
a705315
to
ba52f40
Oct 31, 2016
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Oct 31, 2016
lib/OpenQA/Utils.pm
Outdated
| ); | ||
| my %bugurls = ( | ||
| 'https://bugzilla.novell.com/show_bug.cgi?id=' => 'bsc', | ||
| $bugrefs{bsc} => 'bsc', | ||
| $bugrefs{boo} => 'boo', | ||
| $bugrefs{poo} => 'poo', | ||
| 'https://github.com/' => 'gh', |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
okurz
Nov 1, 2016
Member
probably it differed during my development but does not anymore now. I will correct.
okurz
added some commits
Oct 29, 2016
okurz
force-pushed the
okurz:feature/gh_marker
branch
from
ba52f40
to
402ebd9
Nov 1, 2016
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Nov 1, 2016
aaannz
merged commit 9b625af
into
os-autoinst:master
Nov 2, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
okurz
deleted the
okurz:feature/gh_marker
branch
Nov 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
okurz commentedOct 29, 2016
Add support for generic github repo markers as 'bugrefs
Using the generic profile
'[#<project/repo>]#'
for all bugrefs, especially for github, allows to
track all issues reported on github and especially
test fixing pull requests to be recorded as 'bugrefs'
with the same icon as for "test issues", i.e. poo#.
This way there is no need to create a ticket just
to track a test issue for which already a github
pull request exist because otherwise the URL to the
github PR would not mean anything special to github
and therefore not mark a job as "labeled".
Also, pasting full github URLs is supported, same as
for all other bugrefs, meaning that the URL is
abbreviated into short form bugrefs.
The pattern follows the openSUSE/OBS recommendation.