New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for github 'bugrefs' #973

Merged
merged 3 commits into from Nov 2, 2016

Conversation

Projects
None yet
4 participants
@okurz
Member

okurz commented Oct 29, 2016

Add support for generic github repo markers as 'bugrefs
Using the generic profile
'[#<project/repo>]#'
for all bugrefs, especially for github, allows to
track all issues reported on github and especially
test fixing pull requests to be recorded as 'bugrefs'
with the same icon as for "test issues", i.e. poo#.
This way there is no need to create a ticket just
to track a test issue for which already a github
pull request exist because otherwise the URL to the
github PR would not mean anything special to github
and therefore not mark a job as "labeled".

Also, pasting full github URLs is supported, same as
for all other bugrefs, meaning that the URL is
abbreviated into short form bugrefs.

The pattern follows the openSUSE/OBS recommendation.

@okurz okurz force-pushed the okurz:feature/gh_marker branch from 18869bf to a705315 Oct 29, 2016

@coveralls

This comment has been minimized.

coveralls commented Oct 29, 2016

Coverage Status

Coverage increased (+0.02%) to 72.451% when pulling a705315 on okurz:feature/gh_marker into 21d4009 on os-autoinst:master.

use Test::More;
use Test::Mojo;
use Test::Warnings;
use Test::Output qw/stderr_like/;

This comment has been minimized.

@Martchus

Martchus Oct 31, 2016

Contributor

This is probably not required.

But it might make sense to merge this file with 16-utils-runcmd.t anyways.

This comment has been minimized.

@okurz

okurz Oct 31, 2016

Member

Thanks. Deleted unused uses. But I don't want to merge with 16-utils-runcmd.t which loads the database and is therefore way slower than 16-utils.t which is only using the functions which don't need the database and is near instantly finished.

@okurz okurz force-pushed the okurz:feature/gh_marker branch from a705315 to ba52f40 Oct 31, 2016

@coveralls

This comment has been minimized.

coveralls commented Oct 31, 2016

Coverage Status

Coverage increased (+0.02%) to 72.451% when pulling ba52f40 on okurz:feature/gh_marker into 21d4009 on os-autoinst:master.

);
my %bugurls = (
'https://bugzilla.novell.com/show_bug.cgi?id=' => 'bsc',
$bugrefs{bsc} => 'bsc',
$bugrefs{boo} => 'boo',
$bugrefs{poo} => 'poo',
'https://github.com/' => 'gh',

This comment has been minimized.

@aaannz

aaannz Nov 1, 2016

Member

Just wondering why you didn't use $bugrefs{gh}?

This comment has been minimized.

@okurz

okurz Nov 1, 2016

Member

probably it differed during my development but does not anymore now. I will correct.

okurz added some commits Oct 29, 2016

Add support for github 'bugrefs'
Add support for generic github repo markers as 'bugrefs
Using the generic profile
'<marker>[#<project/repo>]#<id>'
for all bugrefs, especially for github, allows to
track all issues reported on github and especially
test fixing pull requests to be recorded as 'bugrefs'
with the same icon as for "test issues", i.e. poo#.
This way there is no need to create a ticket just
to track a test issue for which already a github
pull request exist because otherwise the URL to the
github PR would not mean anything special to github
and therefore not mark a job as "labeled".

Also, pasting full github URLs is supported, same as
for all other bugrefs, meaning that the URL is
abbreviated into short form bugrefs.

The pattern follows the openSUSE/OBS recommendation.

@okurz okurz force-pushed the okurz:feature/gh_marker branch from ba52f40 to 402ebd9 Nov 1, 2016

@coveralls

This comment has been minimized.

coveralls commented Nov 1, 2016

Coverage Status

Coverage increased (+0.02%) to 72.451% when pulling 402ebd9 on okurz:feature/gh_marker into 21d4009 on os-autoinst:master.

@aaannz

aaannz approved these changes Nov 1, 2016

👍

@aaannz aaannz merged commit 9b625af into os-autoinst:master Nov 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@okurz okurz deleted the okurz:feature/gh_marker branch Nov 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment