From c6cef3a42706531db8ad2807688e3d1502c16d65 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20Dost=C3=A1l?= Date: Tue, 21 May 2024 13:30:01 +0200 Subject: [PATCH 1/3] PC run_ltp define $self->{provider} for cleanup --- tests/publiccloud/run_ltp.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/publiccloud/run_ltp.pm b/tests/publiccloud/run_ltp.pm index ebe4b7063064..09a7e382b77b 100644 --- a/tests/publiccloud/run_ltp.pm +++ b/tests/publiccloud/run_ltp.pm @@ -100,7 +100,7 @@ sub run { $instance = $self->{my_instance} = $args->{my_instance}; $provider = $self->{provider} = $args->{my_provider}; # required for cleanup } else { - $provider = $self->provider_factory(); + $provider = $self->{provider} = $self->provider_factory(); # required for cleanup $instance = $self->{my_instance} = $provider->create_instance(check_guestregister => is_openstack ? 0 : 1); } From a0168b7d555f4c2fba2260db2103530e7cbf70b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20Dost=C3=A1l?= Date: Thu, 23 May 2024 08:31:44 +0200 Subject: [PATCH 2/3] PC ec2 provider: Use terraform output instead of $instance --- lib/publiccloud/ec2.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/publiccloud/ec2.pm b/lib/publiccloud/ec2.pm index ededf466c8fc..c8186e82b8e6 100644 --- a/lib/publiccloud/ec2.pm +++ b/lib/publiccloud/ec2.pm @@ -184,9 +184,9 @@ sub img_proof { sub cleanup { my ($self, $args) = @_; - #if for some reason the instance is not created everything below does not make sense to execute - return unless ($args->{my_instance} && $args->{my_instance}->{instance_id}); - my $instance_id = $args->{my_instance}->{instance_id}; + script_run('cd ~/terraform'); + my $instance_id = script_output('terraform output -json | jq -r ".vm_name.value[0]"', proceed_on_failure => 1); + script_run('cd'); select_host_console(force => 1); From b7023e3f9abd7f3b2bf7018e27f5345e648578ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20Dost=C3=A1l?= Date: Thu, 23 May 2024 08:58:15 +0200 Subject: [PATCH 3/3] PC run_ltp do not run publiccloud::basetest::cleanup twice --- tests/publiccloud/run_ltp.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/publiccloud/run_ltp.pm b/tests/publiccloud/run_ltp.pm index 09a7e382b77b..af8e9ee778f2 100644 --- a/tests/publiccloud/run_ltp.pm +++ b/tests/publiccloud/run_ltp.pm @@ -193,7 +193,6 @@ sub cleanup { script_run("(cd /tmp/log_instance && tar -zcf $root_dir/instance_log.tar.gz *)"); upload_logs("$root_dir/instance_log.tar.gz", failok => 1); } - $self->SUPER::cleanup(); } sub gen_ltp_env {