Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Softfail known samba_adcli failures #13075

Merged
merged 1 commit into from Aug 16, 2021

Conversation

ge0r
Copy link
Member

@ge0r ge0r commented Aug 16, 2021

A number of samba_adcli failures have been identified as seen in
poo#96980.

Those are known failures and should be marked as soft failures,
in order to avoid coverage loss, as they are sporadic and currently
there is less benefit to unschedule the module.

tests/network/samba/samba_adcli.pm Show resolved Hide resolved
tests/network/samba/samba_adcli.pm Outdated Show resolved Hide resolved
@okurz
Copy link
Member

okurz commented Aug 16, 2021

#13072 is the alternative proposal to disable tests temporarily

A number of samba_adcli failures have been identified as seen in
poo#96980.

Those are known failures and should be marked as soft failures,
in order to avoid coverage loss, as they are sporadic and currently
there is less benefit to unschedule the module.
@ge0r ge0r assigned punkioudi and unassigned punkioudi Aug 16, 2021
@ge0r ge0r requested a review from punkioudi August 16, 2021 21:48
Copy link
Contributor

@punkioudi punkioudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm George, I agree with the test being indicated as soft-failed (when it does soft-fails), as the rest of the code might not be executed.

@punkioudi punkioudi merged commit 956b16e into os-autoinst:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants