Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cryptlvm template and templates directory #1678

Merged
merged 2 commits into from Sep 27, 2016
Merged

Conversation

richiejp
Copy link
Contributor

@Soulofdestiny
Copy link
Contributor

Can you please remove the WIP in the commit message?
then LGTM

@richiejp richiejp changed the title WIP: cryptlvm template and templates directory cryptlvm template and templates directory Aug 23, 2016
@richiejp
Copy link
Contributor Author

OK, thanks.

@nilxam
Copy link
Member

nilxam commented Aug 23, 2016

we're testing cryptlvm on GNOME rather than minimalx?
and you created another cryptlvm testsuite which had a little bit different than the old one in templates file, load_template will ignore the later one if had the name is existed in db already. I think I missed the idea of separating.

@richiejp
Copy link
Contributor Author

Yes, we are testing on GNOME; https://openqa.suse.de/tests/525605

From the progress article:
"I find the products/opensuse/templates file to big and painful to deal with. Perhaps a templates sub-directory should be created, which we then insert template files into just containing test suits, machines, job groups etc. which are tightly related.

That way someone can view all the information relating to these tests on one or two pages and import the tests without worrying if anything unexpected is going to be added. If someone needs to add all the templates at once then they can write something like ./load_templates templates/*.

Templates provide a way of recording how a machine or test suit should be used, in a transportable and human readable format, but one huge monolithic file is only useful for automated export-import. I used this template during my local installation by following the instructions, but the number of tests it has added was counter productive when trying to learn the system. If new users want to see a complex setup they can look no further than openqa.suse.de."

@nilxam
Copy link
Member

nilxam commented Aug 23, 2016

sounds templates and templates.d has no relationship between. fine then.

but your change is against openSUSE, openSUSE is using minimalx for cryptlvm test. https://openqa.opensuse.org/tests/247163#settings

@okurz okurz added the notready label Sep 12, 2016
Copy link
Member

@sysrich sysrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richiejp ping - please make the changes suggested

Change cryptlvm job templates to use minimalx instead of gnome as the desktop to be consistent with existing cryptlvm tests.
@okurz okurz removed the notready label Sep 27, 2016
@okurz okurz merged commit b15ccc0 into os-autoinst:master Sep 27, 2016
@richiejp richiejp deleted the ac13140 branch November 8, 2016 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants