New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cryptlvm template and templates directory #1678
Conversation
Can you please remove the WIP in the commit message? |
OK, thanks. |
we're testing cryptlvm on GNOME rather than minimalx? |
Yes, we are testing on GNOME; https://openqa.suse.de/tests/525605 From the progress article: That way someone can view all the information relating to these tests on one or two pages and import the tests without worrying if anything unexpected is going to be added. If someone needs to add all the templates at once then they can write something like ./load_templates templates/*. Templates provide a way of recording how a machine or test suit should be used, in a transportable and human readable format, but one huge monolithic file is only useful for automated export-import. I used this template during my local installation by following the instructions, but the number of tests it has added was counter productive when trying to learn the system. If new users want to see a complex setup they can look no further than openqa.suse.de." |
sounds templates and templates.d has no relationship between. fine then. but your change is against openSUSE, openSUSE is using minimalx for cryptlvm test. https://openqa.opensuse.org/tests/247163#settings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richiejp ping - please make the changes suggested
Change cryptlvm job templates to use minimalx instead of gnome as the desktop to be consistent with existing cryptlvm tests.
See https://progress.opensuse.org/issues/13140