Patch hdd images before offline migration #2225
Conversation
dgutu-suse
force-pushed
the
patch_b4_migration
branch
from
967db97
to
0084b5c
Compare
|
You may want to take a look at some of them - http://ain.arch.suse.de/tests/overview?distri=sle&version=12-SP3&build=0192&groupid=4 |
|
It can be done also without saving additional image, patch in test like here patch instead of ssh_key_check, and of course it will do upgrade when UPGRADE=1 |
|
how does this change relate to https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/2202/files ? |
|
@okurz Don't get what you want to hear |
|
Well, to me it looks related. Isn't it redoing some of the same stuff? I guess you understand better than me what it is supposed to do and what #2202 is supposed to do because I don't understand :-) |
|
@okurz, if you mean the booting from hdd fact then, somehow its but very little :) |
| $email = get_var("SCC_EMAIL"); | ||
| $regcode = get_var("SCC_REGCODE"); | ||
| $regcode_ha = get_var("SCC_REGCODE_HA"); | ||
| $regcode_geo = get_var("SCC_REGCODE_GEO"); |
| @@ -0,0 +1,97 @@ | |||
| # Patch SLE11* qcow2 images before migration (offline) | |||
There was a problem hiding this comment.
that's somehow wrong, you also patch sle12, right? better just delete this line and optionally add something to '# Summary: ' further below
| } | ||
| else { | ||
| $registration = script_output("suse_register -n -a email=$email -a regcode-sles=$regcode", 90); | ||
| } |
There was a problem hiding this comment.
how about setting the options in a string first, e.g. something like
my $regopts;
if (get_required_var('SCC_REGCODE_GEO')) {
$regopts = "regcode-sles=$regcode -a regcode-slehae=$regcode_ha -a regcode-slehaegeo=$regcode_geo";
}
elsif (get_required_var('SCC_REGCODE_HA')) {
$regopts = "regcode-sles=$regcode -a regcode-slehae=$regcode_ha";
}
else {
$regopts = "regcode-sles=$regcode";
}
$registration = script_output("suse_register -n -a email=$email $regopts");should make it a bit more readable and prevents that line break in line 31/32
|
please rebase on current master and make sure your "os-autoinst" subfolder is up to date to use an updated style check. You may have to create a symlink to |
dgutu-suse
force-pushed
the
patch_b4_migration
branch
from
f72412a
to
0084b5c
Compare
|
I'm closing this PR because I re-worked testcase so this one is useless. |
|
@dgutu-suse please don't close PRs just because you are reworking your git history. I don't want to restate all comments in another PR again or look up old PRs to make sure nothing is overlooked. So please reopen this PR with updated changes. |
Patch all hdd images involved in offline migration scenarios.
First will be called the patching step and then the migration will start.
Patching testcases should contain variable PATCH=1